Gets rid of LocationProviderBase.

Gets rid of LocationProviderBase.

It provided very little functionality to just three classes, one of which will be disappearing soon (FakeLocationProvider). All the functionality was protected, meaning removing the interface has no impact outside these three classes.

BUG=637869
Committed: https://crrev.com/409ec48bdceb927a16bbc46f20ecc6a9edd24daa
Cr-Commit-Position: refs/heads/master@{#416047}

[CJ, 2016-08-31 00:53:05]

lethalantidote@chromium.org changed reviewers:
+ mcasas@chromium.org, mvanouwerkerk@chromium.org, wez@chromium.org

[Michael van Ouwerkerk, 2016-08-31 09:44:27]

The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run

[Michael van Ouwerkerk, 2016-08-31 09:44:37]

lgtm with nits

https://codereview.chromium.org/2298013002/diff/1/device/geolocation/fake_loc...
File device/geolocation/fake_location_provider.cc (right):

https://codereview.chromium.org/2298013002/diff/1/device/geolocation/fake_loc...
device/geolocation/fake_location_provider.cc:32: if (!callback_.is_null()) {
nit: no need for curly braces for this one-line body

https://codereview.chromium.org/2298013002/diff/1/device/geolocation/network_...
File device/geolocation/network_location_provider.cc (right):

https://codereview.chromium.org/2298013002/diff/1/device/geolocation/network_...
device/geolocation/network_location_provider.cc:175: if (!callback_.is_null()) {
nit: no curly braces

https://codereview.chromium.org/2298013002/diff/1/device/geolocation/network_...
device/geolocation/network_location_provider.cc:251: if (!callback_.is_null()) {
nit: no curly braces

https://codereview.chromium.org/2298013002/diff/1/device/geolocation/network_...
File device/geolocation/network_location_provider.h (right):

https://codereview.chromium.org/2298013002/diff/1/device/geolocation/network_...
device/geolocation/network_location_provider.h:119:
LocationProvider::LocationProviderUpdateCallback callback_;
Rename this member to location_provider_update_callback_ to distinguish from
wifi_data_update_callback_

[commit-bot: I haz the power, 2016-08-31 09:44:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 10:00:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 10:00:16]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[CJ, 2016-08-31 17:22:11]

https://codereview.chromium.org/2298013002/diff/1/device/geolocation/fake_loc...
File device/geolocation/fake_location_provider.cc (right):

https://codereview.chromium.org/2298013002/diff/1/device/geolocation/fake_loc...
device/geolocation/fake_location_provider.cc:32: if (!callback_.is_null()) {
On 2016/08/31 09:44:37, Michael van Ouwerkerk wrote:
> nit: no need for curly braces for this one-line body

Done.

https://codereview.chromium.org/2298013002/diff/1/device/geolocation/network_...
File device/geolocation/network_location_provider.cc (right):

https://codereview.chromium.org/2298013002/diff/1/device/geolocation/network_...
device/geolocation/network_location_provider.cc:175: if (!callback_.is_null()) {
On 2016/08/31 09:44:37, Michael van Ouwerkerk wrote:
> nit: no curly braces

Done.

https://codereview.chromium.org/2298013002/diff/1/device/geolocation/network_...
device/geolocation/network_location_provider.cc:251: if (!callback_.is_null()) {
On 2016/08/31 09:44:37, Michael van Ouwerkerk wrote:
> nit: no curly braces

Done.

[CJ, 2016-08-31 17:22:21]

The CQ bit was checked by lethalantidote@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 17:22:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 17:42:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 17:42:41]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[CJ, 2016-09-01 00:01:49]

The CQ bit was checked by lethalantidote@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 00:02:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wez, 2016-09-01 02:32:43]

LGTM w/ nits.

nits: CL description needs tidying up:
- It's not clear why LocationProvider being "exported" changes whether
LocationProviderBase is relevant.
- You mention that there are two LocationProvider implementations, one of which
is going away, but there are actually three (network, Android and fake).

:)

[CJ, 2016-09-01 18:27:22]

Description was changed from

==========
Gets rid of LocationProviderBase.

LocationProviderBase no longer makes sense to keep around since
LocationProvider is now exported. It provided very little functionality to
just two classes, one of which will be disappearing soon (FakeLocationProvider).

BUG=637869
==========

to

==========
Gets rid of LocationProviderBase.

It provided very little functionality to
just three classes, one of which will be disappearing soon
(FakeLocationProvider). All the functionality was protected, meaning removing
the interface has no impact outside these three classes. 


BUG=637869
==========

[CJ, 2016-09-01 18:27:52]

Description was changed from

==========
Gets rid of LocationProviderBase.

It provided very little functionality to
just three classes, one of which will be disappearing soon
(FakeLocationProvider). All the functionality was protected, meaning removing
the interface has no impact outside these three classes. 


BUG=637869
==========

to

==========
Gets rid of LocationProviderBase.

It provided very little functionality to just three classes, one of which will
be disappearing soon (FakeLocationProvider). All the functionality was
protected, meaning removing the interface has no impact outside these three
classes. 


BUG=637869
==========

[CJ, 2016-09-01 18:28:01]

The CQ bit was checked by lethalantidote@chromium.org

[CJ, 2016-09-01 18:28:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/2298013002/#ps80001
(title: "wrong branch.")

[commit-bot: I haz the power, 2016-09-01 18:28:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 18:47:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 18:47:13]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[CJ, 2016-09-01 19:37:25]

The CQ bit was checked by lethalantidote@chromium.org

[CJ, 2016-09-01 19:37:25]

The patchset sent to the CQ was uploaded after l-g-t-m from wez@chromium.org,
mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/2298013002/#ps100001
(title: "Typo.")

[commit-bot: I haz the power, 2016-09-01 19:38:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 20:53:20]

Description was changed from

==========
Gets rid of LocationProviderBase.

It provided very little functionality to just three classes, one of which will
be disappearing soon (FakeLocationProvider). All the functionality was
protected, meaning removing the interface has no impact outside these three
classes. 


BUG=637869
==========

to

==========
Gets rid of LocationProviderBase.

It provided very little functionality to just three classes, one of which will
be disappearing soon (FakeLocationProvider). All the functionality was
protected, meaning removing the interface has no impact outside these three
classes. 


BUG=637869
==========

[commit-bot: I haz the power, 2016-09-01 20:53:21]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-01 20:56:07]

Description was changed from

==========
Gets rid of LocationProviderBase.

It provided very little functionality to just three classes, one of which will
be disappearing soon (FakeLocationProvider). All the functionality was
protected, meaning removing the interface has no impact outside these three
classes. 


BUG=637869
==========

to

==========
Gets rid of LocationProviderBase.

It provided very little functionality to just three classes, one of which will
be disappearing soon (FakeLocationProvider). All the functionality was
protected, meaning removing the interface has no impact outside these three
classes.

BUG=637869

Committed: https://crrev.com/409ec48bdceb927a16bbc46f20ecc6a9edd24daa
Cr-Commit-Position: refs/heads/master@{#416047}
==========

[commit-bot: I haz the power, 2016-09-01 20:56:09]

Patchset 6 (id:??) landed as
https://crrev.com/409ec48bdceb927a16bbc46f20ecc6a9edd24daa
Cr-Commit-Position: refs/heads/master@{#416047}