Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2298003003: Don't purge resources for trivial GrContext flushes (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't purge resources for trivial GrContext flushes GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298003003 Committed: https://skia.googlesource.com/skia/+/dc43898bbbd06202562514ae785116e0cc40f825

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix speeling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -12 lines) Patch
M src/gpu/GrContext.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/GrDrawingManager.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrDrawingManager.cpp View 3 chunks +7 lines, -4 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
bsalomon
4 years, 3 months ago (2016-08-31 17:43:21 UTC) #3
robertphillips
lgtm + typo https://codereview.chromium.org/2298003003/diff/1/src/gpu/GrDrawTarget.h File src/gpu/GrDrawTarget.h (right): https://codereview.chromium.org/2298003003/diff/1/src/gpu/GrDrawTarget.h#newcode99 src/gpu/GrDrawTarget.h:99: * Together these two functions flush ...
4 years, 3 months ago (2016-08-31 17:48:07 UTC) #4
bsalomon
https://codereview.chromium.org/2298003003/diff/1/src/gpu/GrDrawTarget.h File src/gpu/GrDrawTarget.h (right): https://codereview.chromium.org/2298003003/diff/1/src/gpu/GrDrawTarget.h#newcode99 src/gpu/GrDrawTarget.h:99: * Together these two functions flush all queued up ...
4 years, 3 months ago (2016-08-31 18:23:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298003003/20001
4 years, 3 months ago (2016-08-31 18:23:21 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 18:53:53 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/dc43898bbbd06202562514ae785116e0cc40f825

Powered by Google App Engine
This is Rietveld 408576698