Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: runtime/vm/benchmark_test.cc

Issue 22980022: Setup a peer for read only strings that are not externalized in (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/benchmark_test.cc
===================================================================
--- runtime/vm/benchmark_test.cc (revision 26385)
+++ runtime/vm/benchmark_test.cc (working copy)
@@ -198,6 +198,8 @@
// Create strings.
uint8_t data8[] = { 'o', 'n', 'e', 0xFF };
int external_peer_data = 123;
+ intptr_t char_size;
+ intptr_t str_len;
Dart_Handle external_string = Dart_NewExternalLatin1String(
data8, ARRAY_SIZE(data8), &external_peer_data, NULL);
Dart_Handle internal_string = NewString("two");
@@ -209,7 +211,12 @@
EXPECT_VALID(external_string);
EXPECT(Dart_IsExternalString(external_string));
void* external_peer = NULL;
- EXPECT_VALID(Dart_ExternalStringGetPeer(external_string, &external_peer));
+ EXPECT_VALID(Dart_StringGetProperties(external_string,
+ &char_size,
+ &str_len,
+ &external_peer));
+ EXPECT_EQ(1, char_size);
+ EXPECT_EQ(4, str_len);
EXPECT_EQ(&external_peer_data, external_peer);
}

Powered by Google App Engine
This is Rietveld 408576698