Documented SystemInfo domain in DevTools protocol.

Source/devtools/protocol.json

Index: Source/devtools/protocol.json
diff --git a/Source/devtools/protocol.json b/Source/devtools/protocol.json
index b4bb75f7b4896efcf9cf649e83e2290fec027406..38711502d25233f1cab639ae84a956624f4557f9 100644
--- a/Source/devtools/protocol.json
+++ b/Source/devtools/protocol.json
@@ -3818,5 +3818,43 @@
                 "name": "tracingComplete"
             }
         ]
+    },
+    {
+        "domain": "SystemInfo",

[pfeldman, 2013/08/14 09:12:58]

You are declaring this domain on the "renderer" target (which corresponds to a
running page). But in reality, you are handling it on the "browser" target in
content. So it does not belong here. Instead, you should move this into
something like content/browser/devtools/browser.json. We will then generate
constants and builders off that file for your handler.

[Ken Russell (switch to Gerrit), 2013/08/14 19:10:24]

OK, I've created a new browser_protocol.json and moved this block to it.

+        "description": "The SystemInfo domain defines methods and events for querying low-level system information.",
+        "hidden": true,
+        "types": [
+            {
+                "id": "GPUDevice",
+                "type": "object",
+                "properties": [
+                    { "name": "vendorId", "type": "number", "description": "PCI ID of the GPU vendor, if available; 0 otherwise." },
+                    { "name": "deviceId", "type": "number", "description": "PCI ID of the GPU device, if available; 0 otherwise." },
+                    { "name": "vendorString", "type": "string", "description": "String description of the GPU vendor, if the PCI ID is not available." },
+                    { "name": "deviceString", "type": "string", "description": "String description of the GPU device, if the PCI ID is not available." }
+                ],
+                "description": "Describes a single graphics processor (GPU)."
+            },
+            {
+                "id": "GPUInfo",
+                "type": "object",
+                "properties": [
+                    { "name": "gpu", "$ref": "GPUDevice", "description": "The primary GPU on the system." },
+                    { "name": "secondaryGpus", "type": "array", "items": { "$ref": "GPUDevice" }, "description": "The secondary GPUs, if any, on the system, or the empty array if none." },

[pfeldman, 2013/08/14 09:12:58]

We don't return empty arrays, but rather declare the parameter "optional". I
would also simply return array of gpus with the first in the list being primary
for simplicity and more compact API surface.

[Ken Russell (switch to Gerrit), 2013/08/14 19:10:24]

Restructured the GPUInfo object per your suggestion.

+                    { "name": "machineModel", "type": "string", "description": "A platform-dependent description of the model of the machine. On Mac OS, this is for example 'MacBookPro10,1'. Will be the empty string if not supported." },

[pfeldman, 2013/08/14 09:12:58]

This seems to be a part of the SystemInfo, but not GPUInfo. I.e. do you want to
have getInfo as a single method returning structured system info?

[Ken Russell (switch to Gerrit), 2013/08/14 19:10:24]

Created a new SystemInfo type and added machineModel and gpu as its two current
fields.

+                    { "name": "optionalAttributes", "type": "object", "optional": "true", "description": "An optional dictionary of additional GPU related attributes." }

[pfeldman, 2013/08/14 09:12:58]

To which GPU these correspond? Sounds like a part of GPUDevice, no?

[Ken Russell (switch to Gerrit), 2013/08/14 19:10:24]

They're general GPU-related attributes and don't correspond to a particular
GPUDevice. Per our discussion I've changed this to an optional auxAttributes
object.

+                ],
+                "description": "Provides information about the GPU(s) on the system."
+            }
+        ],
+        "commands": [
+            {
+                "name": "getGPUInfo",
+                "description": "Returns information about the graphics processor (GPU).",
+                "returns": [
+                    { "name": "info", "$ref": "GPUInfo", "description": "Information about the GPU on the system." }
+                ]
+            }
+        ]
     }]
 }