Documented SystemInfo domain in DevTools protocol.

Documented SystemInfo domain in DevTools protocol.

Per review feedback on https://codereview.chromium.org/21682002/ ,
documented the SystemInfo domain and associated types and methods in
the DevTools protocol. Like the Tracing domain, this domain is hidden
for the time being, until agreement is reached that it will be
publicly documented and supported.

Built and ran all inspector-related layout tests.

BUG=245741

[Ken Russell (switch to Gerrit), 2013-08-14 00:53:32]

Please review. Thanks.

[pfeldman, 2013-08-14 09:12:57]

https://codereview.chromium.org/22980005/diff/1/Source/devtools/protocol.json
File Source/devtools/protocol.json (right):

https://codereview.chromium.org/22980005/diff/1/Source/devtools/protocol.json...
Source/devtools/protocol.json:3823: "domain": "SystemInfo",
You are declaring this domain on the "renderer" target (which corresponds to a
running page). But in reality, you are handling it on the "browser" target in
content. So it does not belong here. Instead, you should move this into
something like content/browser/devtools/browser.json. We will then generate
constants and builders off that file for your handler.

https://codereview.chromium.org/22980005/diff/1/Source/devtools/protocol.json...
Source/devtools/protocol.json:3843: { "name": "secondaryGpus", "type": "array",
"items": { "$ref": "GPUDevice" }, "description": "The secondary GPUs, if any, on
the system, or the empty array if none." },
We don't return empty arrays, but rather declare the parameter "optional". I
would also simply return array of gpus with the first in the list being primary
for simplicity and more compact API surface.

https://codereview.chromium.org/22980005/diff/1/Source/devtools/protocol.json...
Source/devtools/protocol.json:3844: { "name": "machineModel", "type": "string",
"description": "A platform-dependent description of the model of the machine. On
Mac OS, this is for example 'MacBookPro10,1'. Will be the empty string if not
supported." },
This seems to be a part of the SystemInfo, but not GPUInfo. I.e. do you want to
have getInfo as a single method returning structured system info?

https://codereview.chromium.org/22980005/diff/1/Source/devtools/protocol.json...
Source/devtools/protocol.json:3845: { "name": "optionalAttributes", "type":
"object", "optional": "true", "description": "An optional dictionary of
additional GPU related attributes." }
To which GPU these correspond? Sounds like a part of GPUDevice, no?

[Ken Russell (switch to Gerrit), 2013-08-14 19:10:24]

Moved SystemInfo domain to browser_protocol.json and restructured types and
protocol per review feedback.

https://codereview.chromium.org/22980005/diff/1/Source/devtools/protocol.json
File Source/devtools/protocol.json (right):

https://codereview.chromium.org/22980005/diff/1/Source/devtools/protocol.json...
Source/devtools/protocol.json:3823: "domain": "SystemInfo",
On 2013/08/14 09:12:58, pfeldman wrote:
> You are declaring this domain on the "renderer" target (which corresponds to a
> running page). But in reality, you are handling it on the "browser" target in
> content. So it does not belong here. Instead, you should move this into
> something like content/browser/devtools/browser.json. We will then generate
> constants and builders off that file for your handler.

OK, I've created a new browser_protocol.json and moved this block to it.

https://codereview.chromium.org/22980005/diff/1/Source/devtools/protocol.json...
Source/devtools/protocol.json:3843: { "name": "secondaryGpus", "type": "array",
"items": { "$ref": "GPUDevice" }, "description": "The secondary GPUs, if any, on
the system, or the empty array if none." },
On 2013/08/14 09:12:58, pfeldman wrote:
> We don't return empty arrays, but rather declare the parameter "optional". I
> would also simply return array of gpus with the first in the list being
primary
> for simplicity and more compact API surface.

Restructured the GPUInfo object per your suggestion.

https://codereview.chromium.org/22980005/diff/1/Source/devtools/protocol.json...
Source/devtools/protocol.json:3844: { "name": "machineModel", "type": "string",
"description": "A platform-dependent description of the model of the machine. On
Mac OS, this is for example 'MacBookPro10,1'. Will be the empty string if not
supported." },
On 2013/08/14 09:12:58, pfeldman wrote:
> This seems to be a part of the SystemInfo, but not GPUInfo. I.e. do you want
to
> have getInfo as a single method returning structured system info?

Created a new SystemInfo type and added machineModel and gpu as its two current
fields.

https://codereview.chromium.org/22980005/diff/1/Source/devtools/protocol.json...
Source/devtools/protocol.json:3845: { "name": "optionalAttributes", "type":
"object", "optional": "true", "description": "An optional dictionary of
additional GPU related attributes." }
On 2013/08/14 09:12:58, pfeldman wrote:
> To which GPU these correspond? Sounds like a part of GPUDevice, no?

They're general GPU-related attributes and don't correspond to a particular
GPUDevice. Per our discussion I've changed this to an optional auxAttributes
object.

[pfeldman, 2013-08-14 19:31:37]

Content lgtm. It actually belongs downstream (to where the browser target is
defined and implemented). So I'd put it into content/browser/devtools right
away.

https://codereview.chromium.org/22980005/diff/10001/Source/devtools/browser_p...
File Source/devtools/browser_protocol.json (right):

https://codereview.chromium.org/22980005/diff/10001/Source/devtools/browser_p...
Source/devtools/browser_protocol.json:23: { "name": "gpus", "type": "array",
"items": { "$ref": "GPUDevice" }, "description": "The GPU(s) on the system.
Element 0 is the primary GPU." },
nit: "devices" is more pleasant to my non-native ear than gpus.

https://codereview.chromium.org/22980005/diff/10001/Source/devtools/browser_p...
Source/devtools/browser_protocol.json:33: { "name": "machineModel", "type":
"string", "description": "A platform-dependent description of the model of the
machine. On Mac OS, this is, for example, 'MacBookPro 10.1'. Will be the empty
string if not supported." }
nit: Should we follow System Information naming here? My Mac is:
Model Name:	MacBook Pro
Model Identifier:	MacBookPro10,1

I.e. should this be named "modelName"?

[Ken Russell (switch to Gerrit), 2013-08-14 21:17:50]

I'll move this to the other CL https://codereview.chromium.org/21682002/ and
close this one.

https://codereview.chromium.org/22980005/diff/10001/Source/devtools/browser_p...
File Source/devtools/browser_protocol.json (right):

https://codereview.chromium.org/22980005/diff/10001/Source/devtools/browser_p...
Source/devtools/browser_protocol.json:23: { "name": "gpus", "type": "array",
"items": { "$ref": "GPUDevice" }, "description": "The GPU(s) on the system.
Element 0 is the primary GPU." },
On 2013/08/14 19:31:37, pfeldman wrote:
> nit: "devices" is more pleasant to my non-native ear than gpus.

Fine, I'll rename it.

https://codereview.chromium.org/22980005/diff/10001/Source/devtools/browser_p...
Source/devtools/browser_protocol.json:33: { "name": "machineModel", "type":
"string", "description": "A platform-dependent description of the model of the
machine. On Mac OS, this is, for example, 'MacBookPro 10.1'. Will be the empty
string if not supported." }
On 2013/08/14 19:31:37, pfeldman wrote:
> nit: Should we follow System Information naming here? My Mac is:
> Model Name:	MacBook Pro
> Model Identifier:	MacBookPro10,1
> 
> I.e. should this be named "modelName"? 

I'll rename it "modelName". It doesn't really correspond either to the Mac model
name or identifier (in Chrome it's a reformatted model identifier) and I don't
want to require that it precisely match either one.