Issue 22980003: Make HToFastProperties GC safe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22980003: Make HToFastProperties GC safe. (Closed)

Created:
7 years, 4 months ago by Jakob Kummerow

Modified:
7 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make HToFastProperties GC safe. The runtime call can cause a GC, so the instruction must have proper flags set. R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16173

Patch Set 2 : undo kChangesMaps change #

Total comments: 1

Patch Set 3 : addressed comments #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	src/hydrogen-instructions.h	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with a comment. https://codereview.chromium.org/22980003/diff/3001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/22980003/diff/3001/src/hydrogen-instructions.h#newcode6553 src/hydrogen-instructions.h:6553: SetFlag(kChangesNewSpacePromotion); This should be s/SetFlag/SetGVNFlag/ ...

7 years, 4 months ago (2013-08-13 16:21:52 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as r16173.