Issue 2297993002: [Not for review] [Mac] Fullscreen Toolbar Edge Cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2297993002: [Not for review] [Mac] Fullscreen Toolbar Edge Cases

Created:
4 years, 3 months ago by erikchen

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Not for review] [Mac] Fullscreen Toolbar Edge Cases Fixed conflicts between fullscreen toolbar tracking area, visibility locks and animation. BUG=641751, 641749, 642446 patch from issue 2296903002 at patchset 40001 (http://crrev.com/2296903002#ps40001)

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -43 lines)			Patch
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller_private.mm	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h	View	4 chunks	+16 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm	View	14 chunks	+64 lines, -27 lines	0 comments	Download

Dependent Patchsets:

Issue 2296663003 Patch 20001