Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2297983003: [crankshaft] Disable further folding already folded allocations. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Disable further folding already folded allocations. When we try to further fold previously folded allocations in Crankshaft GVN we don't properly transform the allocations involved, which causes the mechanism to leave holes in the new/old space (and thereby violate the iterability property of the new/old space). BUG=chromium:621868 R=jarin@chromium.org Committed: https://crrev.com/7b79224b21a23dfcd44b820c51d9f094b943b862 Cr-Commit-Position: refs/heads/master@{#39040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M src/crankshaft/hydrogen-instructions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 3 chunks +9 lines, -11 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-621868.js View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-08-31 09:26:54 UTC) #1
Jarin
lgtm
4 years, 3 months ago (2016-08-31 09:27:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297983003/1
4 years, 3 months ago (2016-08-31 09:28:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 09:48:05 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 09:48:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b79224b21a23dfcd44b820c51d9f094b943b862
Cr-Commit-Position: refs/heads/master@{#39040}

Powered by Google App Engine
This is Rietveld 408576698