third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp - Issue 2297943002: Rename kAnimatingScrollOnMainThread to kHandlingScrollFromMainThread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

Issue 2297943002: Rename kAnimatingScrollOnMainThread to kHandlingScrollFromMainThread (Closed)

Patch Set: Fix failing tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp b/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

index a8e8fb8da0ee04579b345ad2fa193cc11212fde4..fb47bcb35367065b311f3047fb28efdee9ad1c33 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

@@ -535,7 +535,7 @@ bool ScrollableArea::shouldScrollOnMainThread() const

// TODO(ymalik): We have a non-transient "main thread scrolling reason"

// that doesn't actually cause shouldScrollOnMainThread() to be true.

// This is confusing and should be cleaned up.

- return !!(reasons & ~MainThreadScrollingReason::kAnimatingScrollOnMainThread);

+ return !!(reasons & ~MainThreadScrollingReason::kHandlingScrollFromMainThread);

}

return true;

}