blimp/client/public/compositor/compositor_dependencies.cc - Issue 2297933002: blimp: Set up the CompositorDependencies for blimp in Chrome.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/client/public/compositor/compositor_dependencies.cc

Issue 2297933002: blimp: Set up the CompositorDependencies for blimp in Chrome. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "blimp/client/core/contents/mock_ime_feature_delegate.h"	5 #include "blimp/client/public/compositor/compositor_dependencies.h"

6	6

7 #include "third_party/skia/include/core/SkBitmap.h"	7 #include "cc/output/context_provider.h"

8 #include "url/gurl.h"

9	8

10 namespace blimp {	9 namespace blimp {

11 namespace client {	10 namespace client {

12	11

13 MockImeFeatureDelegate::MockImeFeatureDelegate() {}	12 CompositorDependencies::ContextProviders::ContextProviders() = default;
	David Trainor- moved to gerrit 2016/08/31 00:28:58 Did this not work in the header? Did this not work in the header? Khushal 2016/08/31 21:22:50 It would but then I couldn't forward declare the C Show quoted text On 2016/08/31 00:28:58, David Trainor wrote: > Did this not work in the header? It would but then I couldn't forward declare the ContextProvider, and I thought the preferred style was to not define in the header?
14	13

15 MockImeFeatureDelegate::~MockImeFeatureDelegate() {}	14 CompositorDependencies::ContextProviders::~ContextProviders() = default;

16	15

17 } // namespace client	16 } // namespace client

18 } // namespace blimp	17 } // namespace blimp

OLD	NEW