Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 229793004: Add CharacterData.deleteData()/replaceData() overflow handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/dom/CharacterData.cpp ('K') | « Source/core/dom/CharacterData.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/FrameSelection.cpp
diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp
index 9cc431655955f19aeefa8f2ecdcca3e51b094ef5..f2f39734097e4d0f606ca191c040efcde9d653d5 100644
--- a/Source/core/editing/FrameSelection.cpp
+++ b/Source/core/editing/FrameSelection.cpp
@@ -390,7 +390,7 @@ static Position updatePositionAfterAdoptingTextReplacement(const Position& posit
if (positionOffset > offset + oldLength)
positionOffset = positionOffset - oldLength + newLength;
- ASSERT(positionOffset <= node->length());
+ ASSERT_WITH_SECURITY_IMPLICATION(positionOffset <= node->length());
// CharacterNode in VisibleSelection must be Text node, because Comment
// and ProcessingInstruction node aren't visible.
return Position(toText(node), positionOffset);
« Source/core/dom/CharacterData.cpp ('K') | « Source/core/dom/CharacterData.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698