Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2297903005: DevTools: (anonymous function) ==> (anonymous) (Closed)

Created:
4 years, 3 months ago by paulirish
Modified:
4 years, 3 months ago
Reviewers:
kozy, caseq, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: (anonymous function) ==> (anonymous) (anonymous function) is oft-seen and could use a better signal:noise ratio. Furthermore, in the case of callstacks, we don't want to elide a filename to prioritize showing this function "name". BUG=644580 Committed: https://crrev.com/f1080c137ac52fd7cc673f89c3f91affa5a880f3 Cr-Commit-Position: refs/heads/master@{#417451}

Patch Set 1 #

Patch Set 2 : rebase tests #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : whitespace in tests #

Patch Set 5 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -60 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-fetch-logging-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-resource-errors-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-xhr-logging-async-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt View 1 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/script-as-text-loading-long-url-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console-document-write-from-external-script-logging-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/alert-toString-exception-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-error-on-call-frame-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-exception-report-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-object-literal-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-throw-expected.txt View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-undefined-override-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-before-inspector-open-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-without-console-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-message-contains-async-stack-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-trace-in-eval-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-in-eval-expected.txt View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-worker-nested-imports-syntax-error-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-xpath-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/exception-objects-expected.txt View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/worker-eval-contains-stack-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-profiling.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-profiling-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/heap-profiler-profiling.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/heap-profiler-profiling-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-url-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-grouped-invalidations.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-grouped-invalidations-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (17 generated)
paulirish
kozyatinskiy, you're first (of many) to review. Any concerns here?
4 years, 3 months ago (2016-09-07 01:29:40 UTC) #6
kozy
lgtm https://codereview.chromium.org/2297903005/diff/40001/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-in-eval-expected.txt File third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-in-eval-expected.txt (right): https://codereview.chromium.org/2297903005/diff/40001/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-in-eval-expected.txt#newcode18 third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-in-eval-expected.txt:18: Why new line here?
4 years, 3 months ago (2016-09-07 01:47:35 UTC) #7
paulirish
https://codereview.chromium.org/2297903005/diff/40001/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-in-eval-expected.txt File third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-in-eval-expected.txt (right): https://codereview.chromium.org/2297903005/diff/40001/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-in-eval-expected.txt#newcode18 third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-in-eval-expected.txt:18: On 2016/09/07 at 01:47:34, kozyatinskiy wrote: > Why new ...
4 years, 3 months ago (2016-09-07 01:52:37 UTC) #10
caseq
lgtm
4 years, 3 months ago (2016-09-08 22:55:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297903005/80001
4 years, 3 months ago (2016-09-08 22:57:44 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-09-09 00:34:56 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 00:37:22 UTC) #24
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f1080c137ac52fd7cc673f89c3f91affa5a880f3
Cr-Commit-Position: refs/heads/master@{#417451}

Powered by Google App Engine
This is Rietveld 408576698