Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2297903004: Remove ContentSuggestion::salient_image_url_. (Closed)

Created:
4 years, 3 months ago by sfiera
Modified:
4 years, 3 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContentSuggestion::salient_image_url_. Committed: https://crrev.com/329fc8c46df4686fa4b5d0af050e985e051a35fd Cr-Commit-Position: refs/heads/master@{#415610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M components/ntp_snippets/content_suggestion.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/ntp_snippets/ntp_snippets_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
sfiera
4 years, 3 months ago (2016-08-31 10:14:54 UTC) #2
Marc Treib
lgtm
4 years, 3 months ago (2016-08-31 10:40:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297903004/1
4 years, 3 months ago (2016-08-31 11:29:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 11:32:45 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 11:34:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/329fc8c46df4686fa4b5d0af050e985e051a35fd
Cr-Commit-Position: refs/heads/master@{#415610}

Powered by Google App Engine
This is Rietveld 408576698