Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Side by Side Diff: chrome/browser/extensions/extension_context_menu_model_unittest.cc

Issue 2297863003: Fix initialization for a few more unit_tests under PlzNavigate (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_context_menu_model.h" 5 #include "chrome/browser/extensions/extension_context_menu_model.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
11 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
12 #include "chrome/app/chrome_command_ids.h" 12 #include "chrome/app/chrome_command_ids.h"
13 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h" 13 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
14 #include "chrome/browser/extensions/extension_action_runner.h" 14 #include "chrome/browser/extensions/extension_action_runner.h"
15 #include "chrome/browser/extensions/extension_action_test_util.h" 15 #include "chrome/browser/extensions/extension_action_test_util.h"
16 #include "chrome/browser/extensions/extension_service.h" 16 #include "chrome/browser/extensions/extension_service.h"
17 #include "chrome/browser/extensions/extension_service_test_base.h" 17 #include "chrome/browser/extensions/extension_service_test_base.h"
18 #include "chrome/browser/extensions/menu_manager.h" 18 #include "chrome/browser/extensions/menu_manager.h"
19 #include "chrome/browser/extensions/menu_manager_factory.h" 19 #include "chrome/browser/extensions/menu_manager_factory.h"
20 #include "chrome/browser/extensions/scripting_permissions_modifier.h" 20 #include "chrome/browser/extensions/scripting_permissions_modifier.h"
21 #include "chrome/browser/ui/browser.h" 21 #include "chrome/browser/ui/browser.h"
22 #include "chrome/browser/ui/tabs/tab_strip_model.h" 22 #include "chrome/browser/ui/tabs/tab_strip_model.h"
23 #include "chrome/common/extensions/api/context_menus.h" 23 #include "chrome/common/extensions/api/context_menus.h"
24 #include "chrome/grit/chromium_strings.h" 24 #include "chrome/grit/chromium_strings.h"
25 #include "chrome/grit/generated_resources.h" 25 #include "chrome/grit/generated_resources.h"
26 #include "chrome/test/base/test_browser_window.h" 26 #include "chrome/test/base/test_browser_window.h"
27 #include "chrome/test/base/testing_profile.h" 27 #include "chrome/test/base/testing_profile.h"
28 #include "components/crx_file/id_util.h" 28 #include "components/crx_file/id_util.h"
29 #include "content/public/common/browser_side_navigation_policy.h"
30 #include "content/public/test/browser_side_navigation_test_utils.h"
29 #include "content/public/test/web_contents_tester.h" 31 #include "content/public/test/web_contents_tester.h"
30 #include "extensions/browser/extension_dialog_auto_confirm.h" 32 #include "extensions/browser/extension_dialog_auto_confirm.h"
31 #include "extensions/browser/extension_registry.h" 33 #include "extensions/browser/extension_registry.h"
32 #include "extensions/browser/extension_system.h" 34 #include "extensions/browser/extension_system.h"
33 #include "extensions/browser/test_extension_registry_observer.h" 35 #include "extensions/browser/test_extension_registry_observer.h"
34 #include "extensions/browser/test_management_policy.h" 36 #include "extensions/browser/test_management_policy.h"
35 #include "extensions/common/extension_builder.h" 37 #include "extensions/common/extension_builder.h"
36 #include "extensions/common/feature_switch.h" 38 #include "extensions/common/feature_switch.h"
37 #include "extensions/common/manifest.h" 39 #include "extensions/common/manifest.h"
38 #include "extensions/common/manifest_constants.h" 40 #include "extensions/common/manifest_constants.h"
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 const char* action_key, 128 const char* action_key,
127 Manifest::Location location); 129 Manifest::Location location);
128 const Extension* AddExtensionWithHostPermission( 130 const Extension* AddExtensionWithHostPermission(
129 const std::string& name, 131 const std::string& name,
130 const char* action_key, 132 const char* action_key,
131 Manifest::Location location, 133 Manifest::Location location,
132 const std::string& host_permission); 134 const std::string& host_permission);
133 135
134 Browser* GetBrowser(); 136 Browser* GetBrowser();
135 137
138 void SetUp() override;
139 void TearDown() override;
140
136 private: 141 private:
137 std::unique_ptr<TestBrowserWindow> test_window_; 142 std::unique_ptr<TestBrowserWindow> test_window_;
138 std::unique_ptr<Browser> browser_; 143 std::unique_ptr<Browser> browser_;
139 144
140 DISALLOW_COPY_AND_ASSIGN(ExtensionContextMenuModelTest); 145 DISALLOW_COPY_AND_ASSIGN(ExtensionContextMenuModelTest);
141 }; 146 };
142 147
143 ExtensionContextMenuModelTest::ExtensionContextMenuModelTest() {} 148 ExtensionContextMenuModelTest::ExtensionContextMenuModelTest() {}
144 149
145 const Extension* ExtensionContextMenuModelTest::AddExtension( 150 const Extension* ExtensionContextMenuModelTest::AddExtension(
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 Browser* ExtensionContextMenuModelTest::GetBrowser() { 183 Browser* ExtensionContextMenuModelTest::GetBrowser() {
179 if (!browser_) { 184 if (!browser_) {
180 Browser::CreateParams params(profile()); 185 Browser::CreateParams params(profile());
181 test_window_.reset(new TestBrowserWindow()); 186 test_window_.reset(new TestBrowserWindow());
182 params.window = test_window_.get(); 187 params.window = test_window_.get();
183 browser_.reset(new Browser(params)); 188 browser_.reset(new Browser(params));
184 } 189 }
185 return browser_.get(); 190 return browser_.get();
186 } 191 }
187 192
193 void ExtensionContextMenuModelTest::SetUp() {
194 ExtensionServiceTestBase::SetUp();
195 if (content::IsBrowserSideNavigationEnabled())
196 content::BrowserSideNavigationSetUp();
197 }
198
199 void ExtensionContextMenuModelTest::TearDown() {
200 if (content::IsBrowserSideNavigationEnabled())
201 content::BrowserSideNavigationTearDown();
202 ExtensionServiceTestBase::TearDown();
203 }
204
188 // Tests that applicable menu items are disabled when a ManagementPolicy 205 // Tests that applicable menu items are disabled when a ManagementPolicy
189 // prohibits them. 206 // prohibits them.
190 TEST_F(ExtensionContextMenuModelTest, RequiredInstallationsDisablesItems) { 207 TEST_F(ExtensionContextMenuModelTest, RequiredInstallationsDisablesItems) {
191 InitializeEmptyExtensionService(); 208 InitializeEmptyExtensionService();
192 209
193 // Test that management policy can determine whether or not policy-installed 210 // Test that management policy can determine whether or not policy-installed
194 // extensions can be installed/uninstalled. 211 // extensions can be installed/uninstalled.
195 const Extension* extension = AddExtension( 212 const Extension* extension = AddExtension(
196 "extension", manifest_keys::kPageAction, Manifest::EXTERNAL_POLICY); 213 "extension", manifest_keys::kPageAction, Manifest::EXTERNAL_POLICY);
197 214
(...skipping 492 matching lines...) Expand 10 before | Expand all | Expand 10 after
690 "no_action", nullptr, Manifest::INTERNAL); 707 "no_action", nullptr, Manifest::INTERNAL);
691 ExtensionContextMenuModel menu(no_action, GetBrowser(), 708 ExtensionContextMenuModel menu(no_action, GetBrowser(),
692 ExtensionContextMenuModel::VISIBLE, nullptr); 709 ExtensionContextMenuModel::VISIBLE, nullptr);
693 int inspect_popup_index = 710 int inspect_popup_index =
694 menu.GetIndexOfCommandId(ExtensionContextMenuModel::INSPECT_POPUP); 711 menu.GetIndexOfCommandId(ExtensionContextMenuModel::INSPECT_POPUP);
695 EXPECT_EQ(-1, inspect_popup_index); 712 EXPECT_EQ(-1, inspect_popup_index);
696 } 713 }
697 } 714 }
698 715
699 } // namespace extensions 716 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698