implement kernel -> ssa for simple binary expression

implement kernel -> ssa for simple binary expression

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/227766e4acdc995c749643070b40c758fcae138b

[Harry Terkelsen, 2016-08-30 22:06:19]

het@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-08-31 16:47:46]

lgtm

https://codereview.chromium.org/2297853003/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2297853003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:75: return
_elements.getSelector(getNode(invocation));
it's good to see all of these hooks in one place.

It seems like we should be able to define a selector directly from the
invocation in the future, what to do think?

https://codereview.chromium.org/2297853003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:79: return
_elements.getTypeMask(getNode(invocation));
oh my, I forgot about this one. This is likely going to be the hardest to get
rid of. We might be able to make it work doing something similar to what I
suggested this morning for the list allocation nodes, but I'm not certain.

https://codereview.chromium.org/2297853003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:82: TypeMask
inferredTypeOf(ir.MethodInvocation invocation) {
wonder if we want to call this "selectorTypeOf" or "typeOfSelector"?

[Harry Terkelsen, 2016-08-31 16:57:14]

thanks, Siggi!

https://codereview.chromium.org/2297853003/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2297853003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:75: return
_elements.getSelector(getNode(invocation));
On 2016/08/31 16:47:46, Siggi Cherem (dart-lang) wrote:
> it's good to see all of these hooks in one place.
> 
> It seems like we should be able to define a selector directly from the
> invocation in the future, what to do think?

I think we can. I added a TODO and will do it in a follow-up CL.

https://codereview.chromium.org/2297853003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:79: return
_elements.getTypeMask(getNode(invocation));
On 2016/08/31 16:47:46, Siggi Cherem (dart-lang) wrote:
> oh my, I forgot about this one. This is likely going to be the hardest to get
> rid of. We might be able to make it work doing something similar to what I
> suggested this morning for the list allocation nodes, but I'm not certain.

I'm actually not clear on the different sources of type masks. What is the
difference between ones that come from TreeElements and ones that come from the
global type inference? Why not always use one or the other?

https://codereview.chromium.org/2297853003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:82: TypeMask
inferredTypeOf(ir.MethodInvocation invocation) {
On 2016/08/31 16:47:46, Siggi Cherem (dart-lang) wrote:
> wonder if we want to call this "selectorTypeOf" or "typeOfSelector"?

Done.

[Harry Terkelsen, 2016-08-31 16:59:37]

Description was changed from

==========
implement kernel -> ssa for simple binary expression
==========

to

==========
implement kernel -> ssa for simple binary expression

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/227766e4acdc995c749643070b40c758fcae138b
==========

[Harry Terkelsen, 2016-08-31 16:59:38]

Committed patchset #4 (id:60001) manually as
227766e4acdc995c749643070b40c758fcae138b (presubmit successful).

[Siggi Cherem (dart-lang), 2016-08-31 17:03:39]

https://codereview.chromium.org/2297853003/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2297853003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:79: return
_elements.getTypeMask(getNode(invocation));
On 2016/08/31 16:57:14, Harry Terkelsen wrote:
> On 2016/08/31 16:47:46, Siggi Cherem (dart-lang) wrote:
> > oh my, I forgot about this one. This is likely going to be the hardest to
get
> > rid of. We might be able to make it work doing something similar to what I
> > suggested this morning for the list allocation nodes, but I'm not certain.
> 
> I'm actually not clear on the different sources of type masks. What is the
> difference between ones that come from TreeElements and ones that come from
the
> global type inference? Why not always use one or the other?

I hear you. My understanding is that these are also from the global inference,
they just happen to be stored within the tree-elements because it was cheaper to
put them there.

I'll expose this as part of the "inference results" api once I get to refactor
it. That way everything is fetched one way, even if we decide to store it
efficiently within the nodes.