Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: appengine/swarming/elements/res/imp/tasklist/task-list.html

Issue 2297853002: Make durations look nice on the task list (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/elements/res/imp/tasklist/task-list.html
diff --git a/appengine/swarming/elements/res/imp/tasklist/task-list.html b/appengine/swarming/elements/res/imp/tasklist/task-list.html
index 3a0f288eeec6b1adac73ae8240266ed3eca872c1..5be3c649271cb04061a61c5b53e877dad87250b7 100644
--- a/appengine/swarming/elements/res/imp/tasklist/task-list.html
+++ b/appengine/swarming/elements/res/imp/tasklist/task-list.html
@@ -227,6 +227,7 @@
return this._attribute(task, "costs_usd", 0)[0];
},
created_ts: humanTime("created_ts"),
+ duration: humanTime("duration"),
modified_ts: humanTime("modified_ts"),
started_ts: humanTime("started_ts"),
state: function(task) {
@@ -259,13 +260,14 @@
var aCol = this._attribute(a, attr)[0];
var bCol = this._attribute(b, attr)[0];
- return dir * swarming.naturalCompare(aCol, bCol);
+ return dir * (aCol - bCol);
}
}
var specialSort = {
abandoned_ts: sortableTime("abandoned_ts"),
completed_ts: sortableTime("completed_ts"),
created_ts: sortableTime("created_ts"),
+ duration: sortableTime("duration"),
modified_ts: sortableTime("modified_ts"),
started_ts: sortableTime("started_ts"),
};
@@ -363,7 +365,7 @@
return undefined;
}
// TODO(kjlubick) Make this point to /newui/ when appropriate.
- return "/restricted/task/"+taskId;
+ return "/user/task/"+taskId;
},
_taskClass: function(task) {
« no previous file with comments | « appengine/swarming/elements/build/elements.html ('k') | appengine/swarming/elements/res/imp/tasklist/task-list-data.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698