linux_aura: Use system configuration for middle clicking the titlebar.

linux_aura: Use system configuration for middle clicking the titlebar.

The action that is taken when the user middle clicks on non client area
is configurable with gnome-tweak-tool. This allows users to disable any
action on middle click, lower windows, minimize windows, or toggle the
maximize state.

Also renames GConfTitlebarListener to GConfListener, since it's now
doing more than just checking maximize button order.

BUG=132061
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262839

[Lei Zhang, 2014-04-09 00:47:45]

https://codereview.chromium.org/229783002/diff/1/chrome/browser/ui/libgtk2ui/...
File chrome/browser/ui/libgtk2ui/gconf_listener.cc (right):

https://codereview.chromium.org/229783002/diff/1/chrome/browser/ui/libgtk2ui/...
chrome/browser/ui/libgtk2ui/gconf_listener.cc:27: const char*
kMiddleClickActionKey =
These can be const char foo[], right?

https://codereview.chromium.org/229783002/diff/1/chrome/browser/ui/libgtk2ui/...
chrome/browser/ui/libgtk2ui/gconf_listener.cc:78:
void(GConfListener::*initial_setter)(GConfValue*)) {
Can we change this to a base::Callback instead of using func pointers?

https://codereview.chromium.org/229783002/diff/1/ui/views/linux_ui/linux_ui.h
File ui/views/linux_ui/linux_ui.h (right):

https://codereview.chromium.org/229783002/diff/1/ui/views/linux_ui/linux_ui.h...
ui/views/linux_ui/linux_ui.h:52: ACTION_NONE,
Maybe MIDDLE_CLICK_ACTION_FOO in case we need another set of BAR_ACTION_FOOs
later?

[Elliot Glaysher, 2014-04-09 19:16:37]

ptal

[Lei Zhang, 2014-04-09 19:24:09]

lgtm

[Lei Zhang, 2014-04-09 19:24:13]

The CQ bit was unchecked by thestig@chromium.org

[Lei Zhang, 2014-04-09 19:24:47]

On 2014/04/09 19:24:13, Lei Zhang wrote:
> The CQ bit was unchecked by mailto:thestig@chromium.org

Was gonna CQ, but then realized you may need a ui OWNER.

[Elliot Glaysher, 2014-04-09 19:29:18]

sadrul: ui owners review

[sadrul, 2014-04-09 19:37:37]

LGTM with a couple of comments:

https://codereview.chromium.org/229783002/diff/20001/ui/views/linux_ui/linux_...
File ui/views/linux_ui/linux_ui.h (right):

https://codereview.chromium.org/229783002/diff/20001/ui/views/linux_ui/linux_...
ui/views/linux_ui/linux_ui.h:50: // a middle click in the non client area.
Do you mind mentioning here is that LOWER is the default?

https://codereview.chromium.org/229783002/diff/20001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/x11_window_event_filter.cc (right):

https://codereview.chromium.org/229783002/diff/20001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/x11_window_event_filter.cc:127:
ToggleMaximizedState();
Should you check whether the window can be maximized here (the same as is done
in line 138 below)? Perhaps that check can move into ToggleMaximizedState()?

[Elliot Glaysher, 2014-04-09 20:22:40]

https://codereview.chromium.org/229783002/diff/20001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/x11_window_event_filter.cc (right):

https://codereview.chromium.org/229783002/diff/20001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/x11_window_event_filter.cc:127:
ToggleMaximizedState();
On 2014/04/09 19:37:38, sadrul wrote:
> Should you check whether the window can be maximized here (the same as is done
> in line 138 below)? Perhaps that check can move into ToggleMaximizedState()?

Good catch. I didn't move the property check into the function and just copied
it here because I assume that we don't want to expand the double left click
caption case.

[Elliot Glaysher, 2014-04-09 20:22:44]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2014-04-09 20:23:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/229783002/40001

[commit-bot: I haz the power, 2014-04-09 22:23:42]

Change committed as 262839