Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2297813002: DevTools: Do not run CPU profiler on targets with no JS capability. (Closed)

Created:
4 years, 3 months ago by alph
Modified:
4 years, 3 months ago
Reviewers:
caseq, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Do not run CPU profiler on targets with no JS capability. BUG=642432 Committed: https://crrev.com/56fa67e4c3a979ce739ffd72fa52c498aa3713b8 Cr-Commit-Position: refs/heads/master@{#415454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alph
4 years, 3 months ago (2016-08-30 18:37:45 UTC) #2
dgozman
lgtm
4 years, 3 months ago (2016-08-30 18:47:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297813002/1
4 years, 3 months ago (2016-08-30 18:48:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 22:15:24 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 22:17:18 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/56fa67e4c3a979ce739ffd72fa52c498aa3713b8
Cr-Commit-Position: refs/heads/master@{#415454}

Powered by Google App Engine
This is Rietveld 408576698