tests/ReadPixelsTest.cpp - Issue 22978012: Split SkDevice into SkBaseDevice and SkBitmapDevice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/ReadPixelsTest.cpp

Issue 22978012: Split SkDevice into SkBaseDevice and SkBitmapDevice (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Moved code around to make code review easier Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/ReadPixelsTest.cpp

===================================================================

--- tests/ReadPixelsTest.cpp (revision 10711)

+++ tests/ReadPixelsTest.cpp (working copy)

@@ -313,7 +313,7 @@

for (int glCtxType = 0; glCtxType < glCtxTypeCnt; ++glCtxType) {

SkAutoTUnref<SkDevice> device;

if (0 == dtype) {

- device.reset(new SkDevice(SkBitmap::kARGB_8888_Config, DEV_W, DEV_H, false));

+ device.reset(new SkRasterDevice(SkBitmap::kARGB_8888_Config, DEV_W, DEV_H, false));

} else {

#if SK_SUPPORT_GPU

GrContextFactory::GLContextType type =