experimental/PdfViewer/pdf_viewer_main.cpp - Issue 22978012: Split SkDevice into SkBaseDevice and SkBitmapDevice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: experimental/PdfViewer/pdf_viewer_main.cpp

Issue 22978012: Split SkDevice into SkBaseDevice and SkBitmapDevice (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Updating to ToT (10994) Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: experimental/PdfViewer/pdf_viewer_main.cpp

===================================================================

--- experimental/PdfViewer/pdf_viewer_main.cpp (revision 10994)

+++ experimental/PdfViewer/pdf_viewer_main.cpp (working copy)

@@ -186,7 +186,7 @@

// Exercise all pdf codepaths as in normal rendering, but no actual bits are changed.

if (!FLAGS_config.isEmpty() && strcmp(FLAGS_config[0], "nul") == 0) {

SkBitmap bitmap;

- SkAutoTUnref<SkDevice> device(SkNEW_ARGS(SkDevice, (bitmap)));

+ SkAutoTUnref<SkBaseDevice> device(SkNEW_ARGS(SkBitmapDevice, (bitmap)));

SkNulCanvas canvas(device);

renderer.renderPage(page < 0 ? 0 : page, &canvas, rect);

} else {

@@ -204,9 +204,9 @@

#else

setup_bitmap(&bitmap, (int)SkScalarToDouble(width), (int)SkScalarToDouble(height));

#endif

- SkAutoTUnref<SkDevice> device;

+ SkAutoTUnref<SkBaseDevice> device;

if (strcmp(FLAGS_config[0], "8888") == 0) {

- device.reset(SkNEW_ARGS(SkDevice, (bitmap)));

+ device.reset(SkNEW_ARGS(SkBitmapDevice, (bitmap)));

}

#if SK_SUPPORT_GPU

else if (strcmp(FLAGS_config[0], "gpu") == 0) {

« no previous file with comments | « experimental/PdfViewer/SkTrackDevice.h ('k') | experimental/SkiaExamples/SkExample.cpp » ('j') | no next file with comments »