Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 22978003: Revert r217535 "Move swarm_client to swarming_client." (Closed)

Created:
7 years, 4 months ago by M-A Ruel
Modified:
7 years, 4 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, craigdh+watch_chromium.org, jam, cbentzel+watch_chromium.org, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, frankf+watch_chromium.org, csharp
Visibility:
Public.

Description

Revert r217535 "Move swarm_client to swarming_client." The CL itself is fine but the Try Server didn't gather "got_swarming_client_revision" build property correctly, causing swarm_triggered to use an improper swarm_client checkout. r217535 can be reapplied once the TS is fixed. No other issue was observed. TBR=vadimsh@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217538

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -49 lines) Patch
M .gitignore View 1 chunk +1 line, -1 line 0 comments Download
M DEPS View 2 chunks +4 lines, -6 lines 0 comments Download
M base/base_unittests.isolate View 3 chunks +4 lines, -4 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/isolate.gypi View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser_tests.isolate View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/interactive_ui_tests.isolate View 2 chunks +3 lines, -3 lines 1 comment Download
M chrome/sync_integration_tests.isolate View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/unit_tests.isolate View 3 chunks +4 lines, -4 lines 0 comments Download
M content/content_browsertests.isolate View 3 chunks +4 lines, -4 lines 0 comments Download
M content/content_unittests.isolate View 2 chunks +2 lines, -2 lines 0 comments Download
M net/net_unittests.isolate View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/sharding_supervisor/sharding_supervisor.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
It saddens me to have to do this but I prefer not have all the ...
7 years, 4 months ago (2013-08-14 13:22:27 UTC) #1
M-A Ruel
Committed patchset #1 manually as r217538.
7 years, 4 months ago (2013-08-14 13:23:34 UTC) #2
M-A Ruel
7 years, 4 months ago (2013-08-14 13:26:15 UTC) #3
Message was sent while issue was closed.
https://codereview.chromium.org/22978003/diff/1/chrome/interactive_ui_tests.i...
File chrome/interactive_ui_tests.isolate (right):

https://codereview.chromium.org/22978003/diff/1/chrome/interactive_ui_tests.i...
chrome/interactive_ui_tests.isolate:72:
'../tools/swarm_client/googletest/run_test_cases.py',
Actually, there was an error here. It needed to be swarming_client. I'll fix
this when I reapply the CL.

Powered by Google App Engine
This is Rietveld 408576698