Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2297783006: ui: ozone: drm: synchronize mapped dmabuf with read&write (Closed)

Created:
4 years, 3 months ago by llandwerlin-old
Modified:
4 years, 3 months ago
Reviewers:
dnicoara, dshwang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: ozone: drm: synchronize mapped dmabuf with read&write We're currently starting the synchronization of memory mapped dmabufs only for reading, which means the driver will not flush the CPU cache on DMA_BUF_SYNC_END. As a result we tend to see cache lines on platforms where we don't have an additional cache level like Atom platforms. BUG=475633 TEST=run chrome on chromeos with --enable-native-gpu-memory-buffers and verify we don't have image corruptions when hovering the close/minimize buttons Committed: https://crrev.com/9d43e6183bb0bcfb28d1e1af1fb51210a717e251 Cr-Commit-Position: refs/heads/master@{#417585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
llandwerlin-old
DS: PTAL, thanks!
4 years, 3 months ago (2016-09-01 17:44:02 UTC) #2
dshwang
On 2016/09/01 17:44:02, llandwerlin wrote: > DS: PTAL, thanks! lgtm It fixs Braswell artifact and ...
4 years, 3 months ago (2016-09-09 12:51:34 UTC) #4
llandwerlin-old
dnicoara@chromium.org: PTAL (checked with @dshwang first), thanks!
4 years, 3 months ago (2016-09-09 13:03:48 UTC) #6
dnicoara
lgtm
4 years, 3 months ago (2016-09-09 14:13:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297783006/1
4 years, 3 months ago (2016-09-09 14:14:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 15:00:52 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 15:03:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d43e6183bb0bcfb28d1e1af1fb51210a717e251
Cr-Commit-Position: refs/heads/master@{#417585}

Powered by Google App Engine
This is Rietveld 408576698