Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2297783005: Reland [Telemetry] Convert long running user stories to the System Health format. (Closed)

Created:
4 years, 3 months ago by rnephew (Reviews Here)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland [Telemetry] Convert long running user stories to the System Health format. BUG=639315 Committed: https://crrev.com/1e7e98e048508e3c158244c409830f5a4ebc0630 Cr-Commit-Position: refs/heads/master@{#415996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -0 lines) Patch
M tools/perf/benchmarks/system_health_smoke_test.py View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/perf/page_sets/data/system_health_desktop.json View 1 chunk +4 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/system_health_desktop_028.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/data/system_health_mobile.json View 1 chunk +4 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/system_health_mobile_042.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/system_health/long_running_stories.py View 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
rnephew (Reviews Here)
This includes the sha1 files missing from the first attempt.
4 years, 3 months ago (2016-09-01 16:00:23 UTC) #2
petrcermak
Have you uploaded the WPR files to the cloud storage? You can check this by ...
4 years, 3 months ago (2016-09-01 16:04:08 UTC) #3
rnephew (Reviews Here)
On 2016/09/01 16:04:08, petrcermak wrote: > Have you uploaded the WPR files to the cloud ...
4 years, 3 months ago (2016-09-01 16:17:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297783005/1
4 years, 3 months ago (2016-09-01 16:19:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 18:08:28 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1e7e98e048508e3c158244c409830f5a4ebc0630 Cr-Commit-Position: refs/heads/master@{#415996}
4 years, 3 months ago (2016-09-01 18:09:47 UTC) #9
picksi1
4 years, 3 months ago (2016-09-02 09:20:50 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2294913010/ by picksi@chromium.org.

The reason for reverting is: The long running gmail test enabled by the CL is
failing and turning all the Android perf bots red. See crbug.com/643110/
.

Powered by Google App Engine
This is Rietveld 408576698