Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Issue 2297673002: Port WebGL extension availability tests to the integration test harness. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/gpu/gpu_tests/webgl_conformance_expectations.py
diff --git a/content/test/gpu/gpu_tests/webgl_conformance_expectations.py b/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
index 683ca57202cbaf5688cf884527ff0e29da7df032..a48c9adaf857e1b667bd423a028ce3b372fa2175 100644
--- a/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
+++ b/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
@@ -27,7 +27,7 @@ class WebGLConformanceExpectations(GpuTestExpectations):
def CheckPatternIsValid(self, pattern):
# Look for basic wildcards.
- if not '*' in pattern and not 'WebglExtension.' in pattern:
+ if not '*' in pattern and not 'WebglExtension_' in pattern:
full_path = os.path.normpath(os.path.join(self.conformance_path, pattern))
if not os.path.exists(full_path):
raise Exception('The WebGL conformance test path specified in ' +
@@ -40,61 +40,65 @@ class WebGLConformanceExpectations(GpuTestExpectations):
# It's expected that not all extensions will be available on all platforms.
# Having a test listed here is not necessarily a problem.
- self.Fail('WebglExtension.EXT_color_buffer_float',
+ self.Fail('WebglExtension_EXT_color_buffer_float',
['win', 'mac'])
- self.Fail('WebglExtension.WEBGL_compressed_texture_astc',
+ self.Fail('WebglExtension_WEBGL_compressed_texture_astc',
['win', 'mac', 'linux'])
- self.Fail('WebglExtension.WEBGL_compressed_texture_atc',
+ self.Fail('WebglExtension_WEBGL_compressed_texture_atc',
['win', 'mac', 'linux'])
- self.Fail('WebglExtension.WEBGL_compressed_texture_etc1',
+ self.Fail('WebglExtension_WEBGL_compressed_texture_etc1',
['mac', 'linux'])
- self.Fail('WebglExtension.WEBGL_compressed_texture_pvrtc',
+ self.Fail('WebglExtension_WEBGL_compressed_texture_pvrtc',
['win', 'mac', 'linux'])
# Extensions not available under D3D9
- self.Fail('WebglExtension.EXT_disjoint_timer_query',
+ self.Fail('WebglExtension_EXT_disjoint_timer_query',
['win', 'd3d9'])
- self.Fail('WebglExtension.EXT_sRGB',
+ self.Fail('WebglExtension_EXT_sRGB',
['win', 'd3d9'])
- self.Fail('WebglExtension.WEBGL_compressed_texture_etc1',
+ self.Fail('WebglExtension_WEBGL_compressed_texture_etc1',
['win', 'd3d9'])
- self.Fail('WebglExtension.WEBGL_depth_texture',
+ self.Fail('WebglExtension_WEBGL_depth_texture',
['win', 'amd', 'd3d9'])
- self.Fail('WebglExtension.WEBGL_draw_buffers',
+ self.Fail('WebglExtension_WEBGL_draw_buffers',
['win', 'd3d9'])
# Android general
- self.Fail('WebglExtension.EXT_disjoint_timer_query',
+ self.Fail('WebglExtension_EXT_disjoint_timer_query',
['android'])
- self.Fail('WebglExtension.EXT_frag_depth',
+ self.Fail('WebglExtension_EXT_frag_depth',
['android'])
- self.Fail('WebglExtension.EXT_shader_texture_lod',
+ self.Fail('WebglExtension_EXT_shader_texture_lod',
['android'])
- self.Fail('WebglExtension.WEBGL_compressed_texture_astc',
+ self.Fail('WebglExtension_WEBGL_compressed_texture_astc',
['android'])
- self.Fail('WebglExtension.WEBGL_compressed_texture_pvrtc',
+ self.Fail('WebglExtension_WEBGL_compressed_texture_pvrtc',
['android'])
- self.Fail('WebglExtension.WEBGL_compressed_texture_s3tc',
+ self.Fail('WebglExtension_WEBGL_compressed_texture_s3tc',
['android'])
- self.Fail('WebglExtension.WEBGL_depth_texture',
+ self.Fail('WebglExtension_WEBGL_depth_texture',
['android'])
- self.Fail('WebglExtension.WEBGL_draw_buffers',
+ self.Fail('WebglExtension_WEBGL_draw_buffers',
['android'])
# Nexus 5
- self.Fail('WebglExtension.OES_texture_float_linear',
+ self.Fail('WebglExtension_OES_texture_float_linear',
['android', ('qualcomm', 'Adreno (TM) 330')])
+ # Nexus 5X
+ self.Fail('WebglExtension_EXT_sRGB',
+ ['android', ('qualcomm', 'Adreno (TM) 418')], bug=610951)
+
# Nexus 6 (Adreno 420) and 6P (Adreno 430)
- self.Fail('WebglExtension.EXT_sRGB',
+ self.Fail('WebglExtension_EXT_sRGB',
['android',
('qualcomm', 'Adreno (TM) 420'),
('qualcomm', 'Adreno (TM) 430')])
# Nexus 9
- self.Fail('WebglExtension.WEBGL_compressed_texture_atc',
+ self.Fail('WebglExtension_WEBGL_compressed_texture_atc',
['android', ('nvidia', 'NVIDIA Tegra')])
# ========================
@@ -402,8 +406,6 @@ class WebGLConformanceExpectations(GpuTestExpectations):
# This test is skipped because it is crashing the GPU process.
self.Skip('conformance/glsl/misc/shader-with-non-reserved-words.html',
['android', ('qualcomm', 'Adreno (TM) 418')], bug=609883)
- self.Fail('WebglExtension.EXT_sRGB',
- ['android', ('qualcomm', 'Adreno (TM) 418')], bug=610951)
self.Fail('conformance/textures/misc/' +
'tex-image-and-sub-image-2d-with-array-buffer-view.html',
['android', ('qualcomm', 'Adreno (TM) 418')], bug=610951)

Powered by Google App Engine
This is Rietveld 408576698