Enable goma on pdfium buildbots.

Enable goma on pdfium buildbots by default.

BUG=643139
Committed: https://chromium.googlesource.com/chromium/tools/build/+/c08b45f208a60595ca9f1c0369fca4c0f9cd722f

[tikuta, 2016-09-06 04:30:24]

Description was changed from

==========
Enable goma on pdfium buildbots.

BUG=
==========

to

==========
Enable goma on pdfium buildbots.

BUG=643139
==========

[tikuta, 2016-09-07 08:48:24]

tikuta@chromium.org changed reviewers:
+ dpranke@chromium.org, phajdan.jr@chromium.org, thestig@chromium.org

[tikuta, 2016-09-07 08:48:25]

I made goma module recently to use goma easily.

[Paweł Hajdan Jr., 2016-09-07 16:02:10]

https://codereview.chromium.org/2297663007/diff/40001/scripts/slave/recipes/p...
File scripts/slave/recipes/pdfium.py (right):

https://codereview.chromium.org/2297663007/diff/40001/scripts/slave/recipes/p...
scripts/slave/recipes/pdfium.py:28: 'goma': Property(default=True, kind=bool),
Why is goma being added as build property?

If it's intended as temporary, please add a TODO.

https://codereview.chromium.org/2297663007/diff/40001/scripts/slave/recipes/p...
scripts/slave/recipes/pdfium.py:89: if goma:
Instead of two "if goma" blocks, could you introduce a context manager? "with
goma.(pick-a-name):" that would ensure goma is stopped on exiting the block.

[Dirk Pranke, 2016-09-08 22:01:56]

https://codereview.chromium.org/2297663007/diff/40001/scripts/slave/recipes/p...
File scripts/slave/recipes/pdfium.py (right):

https://codereview.chromium.org/2297663007/diff/40001/scripts/slave/recipes/p...
scripts/slave/recipes/pdfium.py:89: if goma:
On 2016/09/07 16:02:10, Paweł Hajdan Jr. wrote:
> Instead of two "if goma" blocks, could you introduce a context manager? "with
> goma.(pick-a-name):" that would ensure goma is stopped on exiting the block.

Paweł, as far as I know we don't do this anywhere else (or, generally, worry
about stopping goma at all).

Am I wrong?

[tikuta, 2016-09-09 05:08:34]

On 2016/09/08 22:01:56, Dirk Pranke wrote:
>
https://codereview.chromium.org/2297663007/diff/40001/scripts/slave/recipes/p...
> File scripts/slave/recipes/pdfium.py (right):
> 
>
https://codereview.chromium.org/2297663007/diff/40001/scripts/slave/recipes/p...
> scripts/slave/recipes/pdfium.py:89: if goma:
> On 2016/09/07 16:02:10, Paweł Hajdan Jr. wrote:
> > Instead of two "if goma" blocks, could you introduce a context manager?
"with
> > goma.(pick-a-name):" that would ensure goma is stopped on exiting the block.
> 
> Paweł, as far as I know we don't do this anywhere else (or, generally, worry
> about stopping goma at all).
> 
> Am I wrong?

Thank you for review.
yeah, goma module is made recently, few buildbots use goma module yet.

Introducing a context is good idea.

Please ignore this CL until I implement such function.

[Paweł Hajdan Jr., 2016-09-09 08:56:55]

https://codereview.chromium.org/2297663007/diff/40001/scripts/slave/recipes/p...
File scripts/slave/recipes/pdfium.py (right):

https://codereview.chromium.org/2297663007/diff/40001/scripts/slave/recipes/p...
scripts/slave/recipes/pdfium.py:89: if goma:
On 2016/09/08 at 22:01:56, Dirk Pranke wrote:
> Paweł, as far as I know we don't do this anywhere else (or, generally, worry
about stopping goma at all).

I was mostly thinking about duplicated "if goma" and the interface than really
ensuring goma is stopped.

I'd be technically fine with this, it's more of a nit really. I'm more concerned
about adding a "goma" build property above.

[tikuta, 2016-09-13 09:28:53]

Description was changed from

==========
Enable goma on pdfium buildbots.

BUG=643139
==========

to

==========
Enable goma on pdfium buildbots by default.

BUG=643139
==========

[tikuta, 2016-09-13 09:30:11]

PTAL.

I implemented build_with_goma context.

https://codereview.chromium.org/2297663007/diff/40001/scripts/slave/recipes/p...
File scripts/slave/recipes/pdfium.py (right):

https://codereview.chromium.org/2297663007/diff/40001/scripts/slave/recipes/p...
scripts/slave/recipes/pdfium.py:28: 'goma': Property(default=True, kind=bool),
On 2016/09/07 16:02:10, Paweł Hajdan Jr. wrote:
> Why is goma being added as build property?
> 
> If it's intended as temporary, please add a TODO.

Removed

https://codereview.chromium.org/2297663007/diff/40001/scripts/slave/recipes/p...
scripts/slave/recipes/pdfium.py:89: if goma:
On 2016/09/09 08:56:55, Paweł Hajdan Jr. wrote:
> On 2016/09/08 at 22:01:56, Dirk Pranke wrote:
> > Paweł, as far as I know we don't do this anywhere else (or, generally, worry
> about stopping goma at all).
> 
> I was mostly thinking about duplicated "if goma" and the interface than really
> ensuring goma is stopped.
> 
> I'd be technically fine with this, it's more of a nit really. I'm more
concerned
> about adding a "goma" build property above.

use build_with_goma context

[Paweł Hajdan Jr., 2016-09-13 17:22:37]

LGTM

[tikuta, 2016-09-23 03:43:40]

The CQ bit was checked by tikuta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 03:43:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 03:47:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 03:47:59]

Dry run: This issue passed the CQ dry run.

[tikuta, 2016-09-23 05:06:24]

PTAL, Dirk, Lei.

Would you give me LGTM?

[Lei Zhang, 2016-09-23 05:17:22]

Look ok, but I defer to Dirk.

[Dirk Pranke, 2016-09-23 17:50:42]

lgtm w/ comment addressed.

https://codereview.chromium.org/2297663007/diff/80001/scripts/slave/recipes/p...
File scripts/slave/recipes/pdfium.py (right):

https://codereview.chromium.org/2297663007/diff/80001/scripts/slave/recipes/p...
scripts/slave/recipes/pdfium.py:71: 'use_goma=1',
this should be use_goma=true

[tikuta, 2016-09-26 02:24:29]

Thank you for review.

I commit this and keep watching followings.

https://build.chromium.org/p/client.pdfium/console
https://build.chromium.org/p/tryserver.client.pdfium/console

https://codereview.chromium.org/2297663007/diff/80001/scripts/slave/recipes/p...
File scripts/slave/recipes/pdfium.py (right):

https://codereview.chromium.org/2297663007/diff/80001/scripts/slave/recipes/p...
scripts/slave/recipes/pdfium.py:71: 'use_goma=1',
On 2016/09/23 17:50:42, Dirk Pranke wrote:
> this should be use_goma=true

Done.

[tikuta, 2016-09-26 02:24:36]

The CQ bit was checked by tikuta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 02:24:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 02:28:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 02:28:57]

Dry run: This issue passed the CQ dry run.

[tikuta, 2016-09-26 02:32:31]

The CQ bit was checked by tikuta@chromium.org

[tikuta, 2016-09-26 02:32:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2297663007/#ps100001
(title: "use_goma=true")

[commit-bot: I haz the power, 2016-09-26 02:32:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 02:37:00]

Description was changed from

==========
Enable goma on pdfium buildbots by default.

BUG=643139
==========

to

==========
Enable goma on pdfium buildbots by default.

BUG=643139

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/c08b45f208a60595ca9f...
==========

[commit-bot: I haz the power, 2016-09-26 02:37:02]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/tools/build/+/c08b45f208a60595ca9f...

[tikuta, 2016-09-26 02:51:25]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2367253002/ by tikuta@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/client.pdfium/builders/linux/builds/2366

Sorry, I forget to add goma_dir in 'gn gen' step.
https://build.chromium.org/p/client.pdfium/builders/linux/builds/2366/steps/g....