Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2297663003:
[MD settings] change settings card width to 640 (Closed)
|
Created:
4 years, 3 months ago by dschuyler Modified:
4 years, 3 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] change settings card width to 640
This CL reduces the max card width from 960px to 640px.
BUG=642514
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/05b5db68bf23918ab865837f1720525e11f3c72f
Cr-Commit-Position: refs/heads/master@{#416117}
Patch Set 1 #
Total comments: 1
Patch Set 2 : narrowed min-width #Messages
Total messages: 18 (13 generated)
Description was changed from ========== [MD settings] change settings card width to 640 This CL reduces the max card width from 960px to 640px. BUG=642514 ========== to ========== [MD settings] change settings card width to 640 This CL reduces the max card width from 960px to 640px. BUG=642514 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
dschuyler@chromium.org changed reviewers: + dbeam@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm for free reign to play with this, but try to be consistent I don't know that we need to go through the effort of sharing these variables until we're sure what we want. https://codereview.chromium.org/2297663003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page_css.html (right): https://codereview.chromium.org/2297663003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page_css.html:13: min-width: 622px; we should probably adjust this min-width as well. history seems to use 550px, which is what bettes@ asked for on chat https://cs.chromium.org/chromium/src/chrome/browser/resources/md_history/shar...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2297663003/#ps20001 (title: "narrowed min-width")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] change settings card width to 640 This CL reduces the max card width from 960px to 640px. BUG=642514 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] change settings card width to 640 This CL reduces the max card width from 960px to 640px. BUG=642514 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/05b5db68bf23918ab865837f1720525e11f3c72f Cr-Commit-Position: refs/heads/master@{#416117} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/05b5db68bf23918ab865837f1720525e11f3c72f Cr-Commit-Position: refs/heads/master@{#416117} |
