Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2297643003: Revert of Override the webrtc TaskQueue implementation. (Closed)

Created:
4 years, 3 months ago by perkj_chrome
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Override the webrtc TaskQueue implementation. (patchset #3 id:40001 of https://codereview.chromium.org/2291033002/ ) Reason for revert: Actually still breaks Android.... Original issue's description: > Override the webrtc TaskQueue implementation. > Since user32.dll may not be used withing Chrome's sandbox on win 8 at later, we need to override the TaskQueue implementation. This implementation uses base::Thread and the SingleTreadedTaskRunner to post tasks to the queue. > > BUG=webrtc:5687 > NOTRY=true > > Committed: https://crrev.com/e4eba5884297c0224b071a764dfa8a6236887747 > Cr-Commit-Position: refs/heads/master@{#415275} TBR=tommi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5687 Committed: https://crrev.com/9da11463e3a843855f1d59ef6189c66e4b0e6ee2 Cr-Commit-Position: refs/heads/master@{#415276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -357 lines) Patch
D third_party/webrtc_overrides/webrtc/base/task_queue.h View 1 chunk +0 lines, -222 lines 0 comments Download
D third_party/webrtc_overrides/webrtc/base/task_queue.cc View 1 chunk +0 lines, -135 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
perkj_chrome
Created Revert of Override the webrtc TaskQueue implementation.
4 years, 3 months ago (2016-08-30 12:41:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297643003/1
4 years, 3 months ago (2016-08-30 12:42:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 12:43:12 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 12:45:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9da11463e3a843855f1d59ef6189c66e4b0e6ee2
Cr-Commit-Position: refs/heads/master@{#415276}

Powered by Google App Engine
This is Rietveld 408576698