Move DeclarationDescriptor to ParserBase.

Move DeclarationDescriptor to ParserBase.

This is the first step towards unifying ParseVariableDeclarations.

BUG=

Committed: https://crrev.com/4999717e8c60c371c3eaa6a2616a0bbb5bb6778f
Cr-Commit-Position: refs/heads/master@{#39036}

[marja, 2016-08-30 11:53:54]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 11:54:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 12:15:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 12:15:37]

Dry run: This issue passed the CQ dry run.

[marja, 2016-08-30 12:16:30]

Description was changed from

==========
Move DeclarationDescriptor to ParserBase.

This is the first step towards unifying ParseVariableDeclarations.

BUG=
==========

to

==========
Move DeclarationDescriptor to ParserBase.

This is the first step towards unifying ParseVariableDeclarations.

BUG=
==========

[marja, 2016-08-30 12:16:30]

marja@chromium.org changed reviewers:
+ nikolaos@google.com

[nickie, 2016-08-30 14:04:18]

I still find these two classes (the descriptor and the parsing result) very
confusing.
Still the patch LGTM.

[nickie, 2016-08-30 14:04:34]

nikolaos@chromium.org changed reviewers:
+ nikolaos@chromium.org

[nickie, 2016-08-30 14:04:34]

Forgotten comment.

https://codereview.chromium.org/2297643002/diff/1/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2297643002/diff/1/src/parsing/parser-base.h#n...
src/parsing/parser-base.h:635: struct DeclarationDescriptor {
(I'm wondering...)  Would it be better if this were a class, or at least if it
had a constructor that set up the fields?  We now have a series of assignments
in the two places where it's used, in parser.cc.

[nickie, 2016-08-30 14:05:20]

nikolaos@chromium.org changed reviewers:
- nikolaos@google.com

[marja, 2016-08-31 08:29:14]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2016-08-31 08:29:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 08:31:45]

Description was changed from

==========
Move DeclarationDescriptor to ParserBase.

This is the first step towards unifying ParseVariableDeclarations.

BUG=
==========

to

==========
Move DeclarationDescriptor to ParserBase.

This is the first step towards unifying ParseVariableDeclarations.

BUG=
==========

[commit-bot: I haz the power, 2016-08-31 08:31:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-31 08:32:15]

Description was changed from

==========
Move DeclarationDescriptor to ParserBase.

This is the first step towards unifying ParseVariableDeclarations.

BUG=
==========

to

==========
Move DeclarationDescriptor to ParserBase.

This is the first step towards unifying ParseVariableDeclarations.

BUG=

Committed: https://crrev.com/4999717e8c60c371c3eaa6a2616a0bbb5bb6778f
Cr-Commit-Position: refs/heads/master@{#39036}
==========

[commit-bot: I haz the power, 2016-08-31 08:32:16]

Patchset 1 (id:??) landed as
https://crrev.com/4999717e8c60c371c3eaa6a2616a0bbb5bb6778f
Cr-Commit-Position: refs/heads/master@{#39036}

[marja, 2016-08-31 08:38:35]

Forgot to answer comment:

Since in the current situation, the fields are filled in in a different place
than where DeclarationDescriptor is constructed, a ctor doesn't help much.

However, let's work on ideas to make these classes less confusing overall!