Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5237)

Unified Diff: chrome/browser/search_engines/template_url_service_unittest.cc

Issue 229763005: Store default search provider data in dictionary pref. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: put constants in a namespace Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_service_unittest.cc b/chrome/browser/search_engines/template_url_service_unittest.cc
index 91c612c2150165266e13d2bfe457cd9629b58b0c..a3e7689cb48a0d68aec5c17abc0a6e0347c51450 100644
--- a/chrome/browser/search_engines/template_url_service_unittest.cc
+++ b/chrome/browser/search_engines/template_url_service_unittest.cc
@@ -1683,3 +1683,17 @@ TEST_F(TemplateURLServiceTest, ExtensionEngineVsPolicy) {
actual_managed_default = model()->GetDefaultSearchProvider();
ExpectSimilar(expected_managed_default.get(), actual_managed_default);
}
+
+TEST_F(TemplateURLServiceTest, PrefSaving) {
+ // Add a new TemplateURL.
+ test_util_.VerifyLoad();
+ TemplateURL* t_url = AddKeywordWithDate(
+ "name1", "key1", "http://foo1/{searchTerms}", "http://sugg1",
+ std::string(), "http://icon1", true, "UTF-8;UTF-16", Time(), Time());
+ model()->SetUserSelectedDefaultSearchProvider(t_url);
+
+ AssertEquals(*t_url, *model()->GetDefaultSearchProvider());
+ TemplateURL* read_url = NULL;
+ model()->ReadDataFromPrefsDictionary(&read_url);
+ AssertEquals(*read_url, *model()->GetDefaultSearchProvider());
+}
erikwright (departed) 2014/04/22 15:47:24 Are there not some "is equivalent TemplateURL" met
Cait (Slow) 2014/04/22 19:54:13 ExpectSimilar is what we want here I think.

Powered by Google App Engine
This is Rietveld 408576698