Store default search provider data in dictionary pref.

chrome/browser/search_engines/default_search_manager_unittest.cc

Index: chrome/browser/search_engines/default_search_manager_unittest.cc
diff --git a/chrome/browser/search_engines/default_search_manager_unittest.cc b/chrome/browser/search_engines/default_search_manager_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b0be43fb4e803930e8ec3476d0213a78287a1581
--- /dev/null
+++ b/chrome/browser/search_engines/default_search_manager_unittest.cc
@@ -0,0 +1,77 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/files/scoped_temp_dir.h"
+#include "base/strings/string_split.h"
+#include "base/strings/string_util.h"
+#include "base/strings/utf_string_conversions.h"
+#include "base/time/time.h"
+#include "chrome/browser/search_engines/default_search_manager.h"
+#include "chrome/browser/search_engines/template_url.h"
+#include "chrome/test/base/testing_profile.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+// Checks that the two TemplateURLs are similar. It does not check the id, the
+// date_created or the last_modified time.  Neither pointer should be NULL.
+void ExpectSimilar(const TemplateURLData* expected,
+                   const TemplateURLData* actual) {
+  ASSERT_TRUE(expected != NULL);

[erikwright (departed), 2014/04/23 14:18:01]

Don't use ASSERT in a helper function. Many developers do not immediately
understand that it returns on failure, so the fact that it _must_ be an ASSERT
(not an EXPECT) here is not self-evident.

Use two EXPECTs and an if (...) return; instead.

[Cait (Slow), 2014/04/23 19:10:05]

Done.

+  ASSERT_TRUE(actual != NULL);
+  EXPECT_EQ(expected->short_name, actual->short_name);
+  EXPECT_EQ(expected->keyword(), actual->keyword());
+  EXPECT_EQ(expected->url(), actual->url());
+  EXPECT_EQ(expected->suggestions_url, actual->suggestions_url);
+  EXPECT_EQ(expected->favicon_url, actual->favicon_url);
+  EXPECT_EQ(expected->alternate_urls, actual->alternate_urls);
+  EXPECT_EQ(expected->show_in_default_list, actual->show_in_default_list);
+  EXPECT_EQ(expected->safe_for_autoreplace, actual->safe_for_autoreplace);
+  EXPECT_EQ(expected->input_encodings, actual->input_encodings);
+  EXPECT_EQ(expected->search_terms_replacement_key,
+            actual->search_terms_replacement_key);
+}
+
+}  // namespace
+
+class DefaultSearchManagerTest : public testing::Test {
+ public:
+  DefaultSearchManagerTest() {};
+
+  virtual void SetUp() OVERRIDE {
+    // Make unique temp directory.
+    ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
+    profile_.reset(new TestingProfile(temp_dir_.path()));

[erikwright (departed), 2014/04/23 14:18:01]

I believe there is also a TestingPrefService which would serve your needs at a
lower level.

[Cait (Slow), 2014/04/23 19:10:05]

Done.

+  }
+
+  virtual void TearDown() { profile_.reset(); }
+
+  Profile* profile() const { return profile_.get(); }
+
+ private:
+  base::ScopedTempDir temp_dir_;
+  scoped_ptr<Profile> profile_;
+  DISALLOW_COPY_AND_ASSIGN(DefaultSearchManagerTest);
+};
+
+TEST_F(DefaultSearchManagerTest, PrefSaving) {
+  DefaultSearchManager manager;
+  TemplateURLData data;
+  data.short_name = base::UTF8ToUTF16("name1");
+  data.SetKeyword(base::UTF8ToUTF16("key1"));
+  data.SetURL("http://foo1/{searchTerms}");
+  data.suggestions_url = "http://sugg1";
+  data.alternate_urls.push_back( "http://foo1/alt");
+  data.favicon_url = GURL("http://icon1");
+  data.safe_for_autoreplace = true;
+  data.show_in_default_list = true;
+  base::SplitString("UTF-8;UTF-16", ';', &data.input_encodings);
+  data.date_created = base::Time();
+  data.last_modified = base::Time();
+
+  manager.SaveToPrefService(profile()->GetPrefs(), &data);
+  TemplateURLData read_data;
+  manager.ReadFromPrefService(profile()->GetPrefs(), &read_data);
+  ExpectSimilar(&data, &read_data);
+}