Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 229763003: Skip _NETSCAPE_URL population for image drags. (Closed)

Created:
6 years, 8 months ago by dcheng
Modified:
6 years, 8 months ago
Reviewers:
Elliot Glaysher, sky
CC:
chromium-reviews, pkotwicz
Visibility:
Public.

Description

Skip _NETSCAPE_URL population for image drags. Nautilus prefers _NETSCAPE_URL over XDS unfortunately, so we skip setting _NETSCAPE_URL content in this case. BUG=328401 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263059

Patch Set 1 #

Patch Set 2 : Now with more DCHECKs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M ui/base/dragdrop/os_exchange_data_provider_aurax11.cc View 1 3 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
dcheng
I'm a little uncertain about testing. It looks like we have some unit tests for ...
6 years, 8 months ago (2014-04-09 01:26:45 UTC) #1
Elliot Glaysher
On 2014/04/09 01:26:45, dcheng wrote: > I'm a little uncertain about testing. It looks like ...
6 years, 8 months ago (2014-04-09 19:31:15 UTC) #2
dcheng
On 2014/04/09 19:31:15, Elliot Glaysher wrote: > On 2014/04/09 01:26:45, dcheng wrote: > > I'm ...
6 years, 8 months ago (2014-04-09 23:10:27 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 8 months ago (2014-04-09 23:10:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/229763003/10001
6 years, 8 months ago (2014-04-09 23:11:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 23:48:30 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=60510
6 years, 8 months ago (2014-04-09 23:48:31 UTC) #7
dcheng
+sky for OWNERS approval.
6 years, 8 months ago (2014-04-09 23:50:52 UTC) #8
sky
LGTM - how about a test?
6 years, 8 months ago (2014-04-10 15:33:34 UTC) #9
dcheng
I plan on adding a test independent of this patch, since I'd like to try ...
6 years, 8 months ago (2014-04-10 17:44:30 UTC) #10
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 8 months ago (2014-04-10 17:44:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/229763003/10001
6 years, 8 months ago (2014-04-10 17:45:19 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 20:05:09 UTC) #13
Message was sent while issue was closed.
Change committed as 263059

Powered by Google App Engine
This is Rietveld 408576698