|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 3 months ago CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, eyaich1, nednguyen Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSwitch context_lost test to gpu_integration_test harness.
BUG=352807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=zmo@chromium.org
Committed: https://crrev.com/d89cde2c1cfa24e74c97efa88170ed80637f2ae5
Cr-Commit-Position: refs/heads/master@{#415456}
Patch Set 1 #Patch Set 2 : Marked all WebGL 2.0 tests as flaky on Mac. #Patch Set 3 : Rebased. #Patch Set 4 : Undo flaky WebGL 2.0 conformance expectations on Mac. #Patch Set 5 : Switch context_lost test to gpu_integration_test harness. #
Messages
Total messages: 35 (17 generated)
Description was changed from ========== Switch context_lost test to gpu_integration_test harness. BUG=352807 ========== to ========== Switch context_lost test to gpu_integration_test harness. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + zmo@chromium.org
FYI. CQ'ing TBR'd.
Description was changed from ========== Switch context_lost test to gpu_integration_test harness. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Switch context_lost test to gpu_integration_test harness. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org ==========
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
Description was changed from ========== Switch context_lost test to gpu_integration_test harness. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org ========== to ========== Switch context_lost test to gpu_integration_test harness. BUG=352807, 609252 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org ==========
kbr@chromium.org changed reviewers: + vmiura@chromium.org
vmiura: FYI. It's unfortunate that all the WebGL 2.0 tests had to be marked flaky on Mac, but the random GPU process hangs (or, rather, watchdog firings, whether the hangs are real or not) are preventing CLs that touch GPU code from getting through the CQ.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
Ken could you please confirm that it is not this change which is introducing new flakiness? Looking at task logs, try jobs for this CL are showing mass failure across Intel/ATI/Nvidia, in a majority of shards. Other than these try jobs task runs look mostly OK. https://chromium-swarm.appspot.com/user/tasks?limit=1000&sort=created_ts&stat...
On 2016/08/30 20:24:25, vmiura OOO back 8-15 wrote: > Ken could you please confirm that it is not this change which is introducing new > flakiness? > > Looking at task logs, try jobs for this CL are showing mass failure across > Intel/ATI/Nvidia, in a majority of shards. Other than these try jobs task runs > look mostly OK. > > https://chromium-swarm.appspot.com/user/tasks?limit=1000&sort=created_ts&stat... Argh, never mind. I think marking all tests as "flaky" is taking precedence over all the tests marked "failing" beneath.
On 2016/08/30 20:53:38, vmiura OOO back 8-15 wrote: > On 2016/08/30 20:24:25, vmiura OOO back 8-15 wrote: > > Ken could you please confirm that it is not this change which is introducing > new > > flakiness? > > > > Looking at task logs, try jobs for this CL are showing mass failure across > > Intel/ATI/Nvidia, in a majority of shards. Other than these try jobs task > runs > > look mostly OK. > > > > > https://chromium-swarm.appspot.com/user/tasks?limit=1000&sort=created_ts&stat... > > Argh, never mind. I think marking all tests as "flaky" is taking precedence > over all the tests marked "failing" beneath. Thanks for diagnosing it. It's likely that the new wildcard expectations I added are colliding with other wildcard expectations on Mac. I'll undo that change and see whether it will pass the CQ. We need to deal with the WebGL 2.0 conformance suite flakiness though.
The CQ bit was checked by kbr@chromium.org
The CQ bit was unchecked by kbr@chromium.org
Description was changed from ========== Switch context_lost test to gpu_integration_test harness. BUG=352807, 609252 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org ========== to ========== Switch context_lost test to gpu_integration_test harness. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org ==========
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Switch context_lost test to gpu_integration_test harness. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org ========== to ========== Switch context_lost test to gpu_integration_test harness. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Switch context_lost test to gpu_integration_test harness. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org ========== to ========== Switch context_lost test to gpu_integration_test harness. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org Committed: https://crrev.com/d89cde2c1cfa24e74c97efa88170ed80637f2ae5 Cr-Commit-Position: refs/heads/master@{#415456} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/d89cde2c1cfa24e74c97efa88170ed80637f2ae5 Cr-Commit-Position: refs/heads/master@{#415456}
Message was sent while issue was closed.
On 2016/08/30 22:19:40, commit-bot: I haz the power wrote: > Patchset 4 (id:??) landed as > https://crrev.com/d89cde2c1cfa24e74c97efa88170ed80637f2ae5 > Cr-Commit-Position: refs/heads/master@{#415456} I suspect this breaks Android.
Message was sent while issue was closed.
On 2016/08/31 01:15:05, ynovikov wrote: > On 2016/08/30 22:19:40, commit-bot: I haz the power wrote: > > Patchset 4 (id:??) landed as > > https://crrev.com/d89cde2c1cfa24e74c97efa88170ed80637f2ae5 > > Cr-Commit-Position: refs/heads/master@{#415456} > > I suspect this breaks Android. Sorry about that. I'll revert and diagnose.
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2292323003/ by kbr@chromium.org. The reason for reverting is: Broke context_lost tests on Android as seen on https://build.chromium.org/p/chromium.gpu.fyi/console . .
Message was sent while issue was closed.
I accidentally uploaded another patch set to this CL instead of creating a new one. Re-uploading into https://codereview.chromium.org/2299083002 . |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
