Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2297623002: Switch context_lost test to gpu_integration_test harness. (Closed)

Created:
4 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 3 months ago
Reviewers:
Zhenyao Mo, vmiura
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, eyaich1, nednguyen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch context_lost test to gpu_integration_test harness. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org Committed: https://crrev.com/d89cde2c1cfa24e74c97efa88170ed80637f2ae5 Cr-Commit-Position: refs/heads/master@{#415456}

Patch Set 1 #

Patch Set 2 : Marked all WebGL 2.0 tests as flaky on Mac. #

Patch Set 3 : Rebased. #

Patch Set 4 : Undo flaky WebGL 2.0 conformance expectations on Mac. #

Patch Set 5 : Switch context_lost test to gpu_integration_test harness. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -121 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 1 2 3 4 2 chunks +7 lines, -7 lines 0 comments Download
M content/test/gpu/gpu_tests/context_lost_expectations.py View 1 2 3 4 3 chunks +12 lines, -12 lines 0 comments Download
M content/test/gpu/gpu_tests/context_lost_integration_test.py View 1 2 3 4 3 chunks +13 lines, -12 lines 0 comments Download
M testing/buildbot/chromium.gpu.json View 9 chunks +18 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 1 2 3 4 36 chunks +72 lines, -72 lines 0 comments Download

Messages

Total messages: 35 (17 generated)
Ken Russell (switch to Gerrit)
FYI. CQ'ing TBR'd.
4 years, 3 months ago (2016-08-30 11:21:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297623002/1
4 years, 3 months ago (2016-08-30 11:21:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/3021)
4 years, 3 months ago (2016-08-30 12:01:10 UTC) #8
Ken Russell (switch to Gerrit)
vmiura: FYI. It's unfortunate that all the WebGL 2.0 tests had to be marked flaky ...
4 years, 3 months ago (2016-08-30 13:26:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297623002/20001
4 years, 3 months ago (2016-08-30 13:26:43 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/248276)
4 years, 3 months ago (2016-08-30 13:37:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297623002/40001
4 years, 3 months ago (2016-08-30 18:08:54 UTC) #17
commit-bot: I haz the power
Exceeded global retry quota
4 years, 3 months ago (2016-08-30 20:11:24 UTC) #19
vmiura
Ken could you please confirm that it is not this change which is introducing new ...
4 years, 3 months ago (2016-08-30 20:24:25 UTC) #20
vmiura
On 2016/08/30 20:24:25, vmiura OOO back 8-15 wrote: > Ken could you please confirm that ...
4 years, 3 months ago (2016-08-30 20:53:38 UTC) #21
Ken Russell (switch to Gerrit)
On 2016/08/30 20:53:38, vmiura OOO back 8-15 wrote: > On 2016/08/30 20:24:25, vmiura OOO back ...
4 years, 3 months ago (2016-08-30 21:02:31 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297623002/60001
4 years, 3 months ago (2016-08-30 21:03:50 UTC) #27
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-30 22:17:22 UTC) #29
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/d89cde2c1cfa24e74c97efa88170ed80637f2ae5 Cr-Commit-Position: refs/heads/master@{#415456}
4 years, 3 months ago (2016-08-30 22:19:40 UTC) #31
ynovikov
On 2016/08/30 22:19:40, commit-bot: I haz the power wrote: > Patchset 4 (id:??) landed as ...
4 years, 3 months ago (2016-08-31 01:15:05 UTC) #32
Ken Russell (switch to Gerrit)
On 2016/08/31 01:15:05, ynovikov wrote: > On 2016/08/30 22:19:40, commit-bot: I haz the power wrote: ...
4 years, 3 months ago (2016-08-31 01:34:09 UTC) #33
Ken Russell (switch to Gerrit)
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2292323003/ by kbr@chromium.org. ...
4 years, 3 months ago (2016-08-31 01:34:52 UTC) #34
Ken Russell (switch to Gerrit)
4 years, 3 months ago (2016-09-01 00:16:21 UTC) #35
Message was sent while issue was closed.
I accidentally uploaded another patch set to this CL instead of creating a new
one. Re-uploading into https://codereview.chromium.org/2299083002 .

Powered by Google App Engine
This is Rietveld 408576698