Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2297603004: Revert of Move DIP scale away from AwContents (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move DIP scale away from AwContents (patchset #2 id:20001 of https://codereview.chromium.org/2288273003/ ) Reason for revert: Android build failure. https://build.chromium.org/p/chromium/builders/Android/builds/61497/steps/compile/logs/stdio Original issue's description: > Move DIP scale away from AwContents > > This small refactoring removes device scale factor from AwContents > cache and uses the value from ContentViewCore. > The device scale factor in ContentViewCore is defined after > ContentViewCore native initialization, therefore this CL also > moves the device scale propagation until after that. > > This is a prerequisite for https://codereview.chromium.org/2300463002 > > BUG=632461 > > Committed: https://crrev.com/8d849fd2d39c9db747f4e8d89dcedfebb0273a97 > Cr-Commit-Position: refs/heads/master@{#415546} TBR=boliu@chromium.org,sievers@chromium.org,timav@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=632461 Committed: https://crrev.com/e4a4c8ba3ccdba792582595d3fef6c2d7414a149 Cr-Commit-Position: refs/heads/master@{#415551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 8 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Created Revert of Move DIP scale away from AwContents
4 years, 3 months ago (2016-08-31 04:02:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297603004/1
4 years, 3 months ago (2016-08-31 04:03:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 04:05:37 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 04:09:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4a4c8ba3ccdba792582595d3fef6c2d7414a149
Cr-Commit-Position: refs/heads/master@{#415551}

Powered by Google App Engine
This is Rietveld 408576698