[sensors] Don't call OnSensorReadingChanged if client's suspended.

[sensors] Don't call OnSensorReadingChanged if client's suspended.

Add check that tests client is not suspended. If not,
OnSensorReadingChanged is called on that client.

Committed: https://crrev.com/71f9df8fd50edafaccddcae2487410509058fcf1
Cr-Commit-Position: refs/heads/master@{#415565}

[maksims (do not use this acc), 2016-08-30 10:02:33]

Description was changed from

==========
Fixing sending notification onreadingchange to clients with suspended
notifications

BUG=
==========

to

==========
[sensors] Don't call OnSensorReadingChanged if client's suspended.

Add check that tests client is not suspended. If not, 
OnSensorReadingChanged is called on that client.
==========

[maksims (do not use this acc), 2016-08-30 10:02:33]

maksim.sisov@intel.com changed reviewers:
+ alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com

[maksims (do not use this acc), 2016-08-30 10:03:45]

Patchset #1 (id:1) has been deleted

[maksims (do not use this acc), 2016-08-30 10:04:01]

please review

[Mikhail, 2016-08-30 10:27:37]

https://codereview.chromium.org/2297593002/diff/40001/device/generic_sensor/p...
File device/generic_sensor/platform_sensor.cc (right):

https://codereview.chromium.org/2297593002/diff/40001/device/generic_sensor/p...
device/generic_sensor/platform_sensor.cc:87: if
(client->IsNotificationSuspended())
if (!client->IsNotificationSuspended())
  client->OnSensorReadingChanged();

https://codereview.chromium.org/2297593002/diff/40001/device/generic_sensor/p...
File device/generic_sensor/platform_sensor.h (right):

https://codereview.chromium.org/2297593002/diff/40001/device/generic_sensor/p...
device/generic_sensor/platform_sensor.h:74: typedef base::ObserverList<Client,
true> ClientsList;
I don't think we need it here: 'base::ObserverList' is a common pattern in
chromium which is better to declare explicitly.

You could add 'using ClientsList = base::ObserverList<Client, true> (or simply
decltype(clients_))' right inside 'NotifySensorReadingChanged' method body.

[maksims (do not use this acc), 2016-08-30 11:11:30]

https://codereview.chromium.org/2297593002/diff/40001/device/generic_sensor/p...
File device/generic_sensor/platform_sensor.cc (right):

https://codereview.chromium.org/2297593002/diff/40001/device/generic_sensor/p...
device/generic_sensor/platform_sensor.cc:87: if
(client->IsNotificationSuspended())
On 2016/08/30 10:27:37, Mikhail wrote:
> if (!client->IsNotificationSuspended())
>   client->OnSensorReadingChanged();

Done.

https://codereview.chromium.org/2297593002/diff/40001/device/generic_sensor/p...
File device/generic_sensor/platform_sensor.h (right):

https://codereview.chromium.org/2297593002/diff/40001/device/generic_sensor/p...
device/generic_sensor/platform_sensor.h:74: typedef base::ObserverList<Client,
true> ClientsList;
On 2016/08/30 10:27:37, Mikhail wrote:
> I don't think we need it here: 'base::ObserverList' is a common pattern in
> chromium which is better to declare explicitly.
> 
> You could add 'using ClientsList = base::ObserverList<Client, true> (or simply
> decltype(clients_))' right inside 'NotifySensorReadingChanged' method body.

Done.

[maksims (do not use this acc), 2016-08-30 11:44:36]

Patchset #2 (id:40001) has been deleted

[maksims (do not use this acc), 2016-08-30 11:44:42]

Patchset #1 (id:20001) has been deleted

[maksims (do not use this acc), 2016-08-30 11:48:51]

Patchset #1 (id:60001) has been deleted

[maksims (do not use this acc), 2016-08-30 11:51:32]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 11:51:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-08-30 12:00:18]

lgtm

[commit-bot: I haz the power, 2016-08-30 12:59:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 12:59:06]

Dry run: This issue passed the CQ dry run.

[maksims (do not use this acc), 2016-08-31 05:15:33]

The CQ bit was checked by maksim.sisov@intel.com

[commit-bot: I haz the power, 2016-08-31 05:15:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 05:19:09]

Description was changed from

==========
[sensors] Don't call OnSensorReadingChanged if client's suspended.

Add check that tests client is not suspended. If not, 
OnSensorReadingChanged is called on that client.
==========

to

==========
[sensors] Don't call OnSensorReadingChanged if client's suspended.

Add check that tests client is not suspended. If not, 
OnSensorReadingChanged is called on that client.
==========

[commit-bot: I haz the power, 2016-08-31 05:19:10]

Committed patchset #1 (id:80001)

[commit-bot: I haz the power, 2016-08-31 05:21:12]

Description was changed from

==========
[sensors] Don't call OnSensorReadingChanged if client's suspended.

Add check that tests client is not suspended. If not, 
OnSensorReadingChanged is called on that client.
==========

to

==========
[sensors] Don't call OnSensorReadingChanged if client's suspended.

Add check that tests client is not suspended. If not,
OnSensorReadingChanged is called on that client.

Committed: https://crrev.com/71f9df8fd50edafaccddcae2487410509058fcf1
Cr-Commit-Position: refs/heads/master@{#415565}
==========

[commit-bot: I haz the power, 2016-08-31 05:21:13]

Patchset 1 (id:??) landed as
https://crrev.com/71f9df8fd50edafaccddcae2487410509058fcf1
Cr-Commit-Position: refs/heads/master@{#415565}