Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2297523002: Release streamed script resources after it was compiled (Closed)

Created:
4 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Release streamed script resources after it was compiled Otherwise, we'd hold on to the resources until the embedder frees them which might take a long time R=marja@chromium.org,verwaest@chromium.org BUG= Committed: https://crrev.com/877dac34465c018bb534b7781fbe242ae4e33c32 Cr-Commit-Position: refs/heads/master@{#38999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M src/api.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/background-parsing-task.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
jochen (gone - plz use gerrit)
4 years, 3 months ago (2016-08-30 08:20:01 UTC) #1
marja
lgtm
4 years, 3 months ago (2016-08-30 08:23:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297523002/1
4 years, 3 months ago (2016-08-30 08:24:50 UTC) #7
Toon Verwaest
Woohoogtm
4 years, 3 months ago (2016-08-30 08:42:05 UTC) #8
Michael Lippautz
On 2016/08/30 08:42:05, Toon Verwaest wrote: > Woohoogtm \o/ verified the behavior \o/ lgtm
4 years, 3 months ago (2016-08-30 08:55:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 09:40:23 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/877dac34465c018bb534b7781fbe242ae4e33c32 Cr-Commit-Position: refs/heads/master@{#38999}
4 years, 3 months ago (2016-08-30 09:41:02 UTC) #12
Michael Achenbach
4 years, 3 months ago (2016-08-30 12:37:33 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2290173003/ by machenbach@chromium.org.

The reason for reverting is: Seems to break webkit unit tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%....

Powered by Google App Engine
This is Rietveld 408576698