Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2297513002: Revert of Delete roll-dep-svn (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
Reviewers:
dnj, agable
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Delete roll-dep-svn (patchset #1 id:1 of https://codereview.chromium.org/2282223002/ ) Reason for revert: Still in use. Breaks the v8 auto-rollers. https://cs.chromium.org/search/?q=roll-dep-svn&sq=package:chromium&type=cs Original issue's description: > Delete roll-dep-svn > > R=dnj@chromium.org > BUG=475320 > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/96ebc1d0e100021990312072e6eda6b8a0a81ee5 TBR=dnj@chromium.org,agable@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=475320 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/26a201f2a9da493772dfc4bc1a498b200e6c801d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+435 lines, -0 lines) Patch
A roll-dep-svn View 1 chunk +8 lines, -0 lines 0 comments Download
A roll-dep-svn.bat View 1 chunk +10 lines, -0 lines 0 comments Download
A roll_dep_svn.py View 1 chunk +417 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Delete roll-dep-svn
4 years, 3 months ago (2016-08-30 07:43:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297513002/1
4 years, 3 months ago (2016-08-30 07:43:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/26a201f2a9da493772dfc4bc1a498b200e6c801d
4 years, 3 months ago (2016-08-30 07:43:17 UTC) #5
Michael Achenbach
4 years, 3 months ago (2016-08-30 07:47:47 UTC) #6
Message was sent while issue was closed.
I've had no cycles to switch to the other script - maybe end of quarter. I
remember, the new script didn't do what we needed, while the other one did
(despite the "svn" in the name, it does work with git as well).

Powered by Google App Engine
This is Rietveld 408576698