Save password functionality added to the save password bubble

chrome/browser/password_manager/password_form_manager.h

Index: chrome/browser/password_manager/password_form_manager.h
diff --git a/chrome/browser/password_manager/password_form_manager.h b/chrome/browser/password_manager/password_form_manager.h
index 877729908a3cae9cd0c2c6adcad5cd15fed6e344..e30642b4015324c96dbff0bea448dad231ebb59f 100644
--- a/chrome/browser/password_manager/password_form_manager.h
+++ b/chrome/browser/password_manager/password_form_manager.h
@@ -71,6 +71,14 @@ class PasswordFormManager : public PasswordStoreConsumer {
   // the same thread!
   bool HasCompletedMatching();
 
+  // Save password according to current password_form. If the user has chosen

[Garrett Casto, 2013/08/27 00:52:24]

I'm not sure that I understand the need for these changes. Shouldn't this use
the same code the InfoBar is currently using (Save() to save and
PermanentlyDelete() to blacklist)? Is there a reason why the functionality
should be different?

[npentrel, 2013/08/27 16:35:11]

Yes, the functionality needs to be slightly different as we now allow for the
user to click on the icon again and change the choice the user previously made.
Hence the user can save a password, then click on the icon again and blacklist
it.

But you are right, there is no need for DeleteSavedPassword.

On 2013/08/27 00:52:24, Garrett Casto wrote:

[Garrett Casto, 2013/08/28 00:08:33]

In that case, shouldn't we just wait until navigation has occurred (and the icon
has disappeared) before committing their decision to the database? Actually
trying to save both if the user clicks back and forth seems more complicated
than it has to be. For instance, if the user clicked blacklist and then save you
would need to remove the blacklist credential during saving, which we currently
don't do. 

[npentrel, 2013/08/28 08:48:44]

We have the following two cases:

1. User saves password -> user blacklists password
In this case we don't have to change anything.

2. User blacklists password -> user saves password
In this case all we need to do is (re)set
pending_credentials_.blacklisted_by_user to false. This will take the saved
password off the blacklisted password list.

Hence, I believe that this change is easier and smaller than implementing a way
to listen for the icon to disappear on the next navigation. If we did this, I am
also not sure whether closing the tab would be understood as a navigation in
order for the password to be saved in the case that someone logs in, saves the
password, and closes the tab before the icon disappears. 

We should also consider that the icon is displayed on some pages until the user
logs out, in the case that the browser crashed during that time period, the
password would also not be saved. We can circumvent this by saving
it/blacklisting it on click.


On 2013/08/28 00:08:33, Garrett Casto wrote:

+  // to blacklist the password previously this will undo this action and save
+  // the password.
+  void SavePassword();
+
+  // Delete saved password according to current password_form.
+  void DeleteSavedPassword();
+
   // Determines if the user opted to 'never remember' passwords for this form.
   bool IsBlacklisted();