Save password functionality added to the save password bubble

chrome/browser/password_manager/password_form_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_form_manager.h"
 
 #include <algorithm>
 
 #include "base/metrics/histogram.h"
 #include "base/strings/string_split.h"
@@ skipping 88 matching lines @@
                          form.origin.spec().end(),
                          after_scheme2,
                          observed_form_.origin.spec().end())
                          != form.origin.spec().end();
     }
     return false;
   }
   return true;
 }
 
+void PasswordFormManager::SavePassword() {
+  PasswordStore* password_store = PasswordStoreFactory::GetForProfile(
+      profile_, Profile::EXPLICIT_ACCESS).get();
+  if (!password_store) {
+    NOTREACHED();
+    return;
+  }

[Garrett Casto, 2013/08/28 00:08:33]

Note, there should be no reason to do this, the password store is checked in
both SaveAsNewLogin() and UpdateLogin() when it is actually used.

[npentrel, 2013/08/28 08:48:44]

Done.

+  DCHECK_EQ(state_, POST_MATCHING_PHASE);
+
+  // Configure the form about to be saved for non-blacklisted status.
+  // This is done as the user can choose to blacklist the password and then
+  // undo the previously selected and save the password.
+  pending_credentials_.preferred = true;
+  pending_credentials_.blacklisted_by_user = false;
+
+  // Save the pending_credentials_ entry marked as not-blacklisted.
+  DCHECK(!profile_->IsOffTheRecord());
+  if (IsNewLogin()) {
+    SaveAsNewLogin(true);
+  } else {
+    UpdateLogin();
+  }
+}
+
 bool PasswordFormManager::IsBlacklisted() {
   DCHECK_EQ(state_, POST_MATCHING_PHASE);
   if (preferred_match_ && preferred_match_->blacklisted_by_user)
     return true;
   return false;
 }
 
 void PasswordFormManager::PermanentlyBlacklist() {
   DCHECK_EQ(state_, POST_MATCHING_PHASE);
 
   // Configure the form about to be saved for blacklist status.
   pending_credentials_.preferred = true;
   pending_credentials_.blacklisted_by_user = true;
-  pending_credentials_.username_value.clear();
-  pending_credentials_.password_value.clear();
 
   // Retroactively forget existing matches for this form, so we NEVER prompt or
   // autofill it again.
   if (!best_matches_.empty()) {
     PasswordFormMap::const_iterator iter;
     PasswordStore* password_store = PasswordStoreFactory::GetForProfile(
         profile_, Profile::EXPLICIT_ACCESS).get();
     if (!password_store) {
       NOTREACHED();
       return;
@@ skipping 456 matching lines @@
 
 void PasswordFormManager::SubmitFailed() {
   submit_result_ = kSubmitResultFailed;
 }
 
 void PasswordFormManager::SendNotBlacklistedToRenderer() {
   content::RenderViewHost* host = web_contents_->GetRenderViewHost();
   host->Send(new AutofillMsg_FormNotBlacklisted(host->GetRoutingID(),
                                                  observed_form_));
 }