Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2297493002: Revert of Add OfflinePageSuggestionsProviderTest (Closed)

Created:
4 years, 3 months ago by perkj_chrome
Modified:
4 years, 3 months ago
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add OfflinePageSuggestionsProviderTest (patchset #10 id:180001 of https://codereview.chromium.org/2279223002/ ) Reason for revert: Fails on Chrome os. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/25426 Original issue's description: > Add OfflinePageSuggestionsProviderTest > > BUG=628198 > > Committed: https://crrev.com/5fe00b8dfc81a113eb3d02641cf71daff59b5fa0 > Cr-Commit-Position: refs/heads/master@{#415211} TBR=treib@chromium.org,tschumann@chromium.org,dsansome@chromium.org,pke@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=628198 Committed: https://crrev.com/e92cad1f144ad608599fb56eba9dc49b20a31da4 Cr-Commit-Position: refs/heads/master@{#415231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -414 lines) Patch
M components/ntp_snippets/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download
D components/ntp_snippets/offline_pages/offline_page_suggestions_provider_unittest.cc View 1 chunk +0 lines, -409 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
perkj_chrome
Created Revert of Add OfflinePageSuggestionsProviderTest
4 years, 3 months ago (2016-08-30 07:24:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297493002/1
4 years, 3 months ago (2016-08-30 07:25:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 07:27:36 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 07:31:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e92cad1f144ad608599fb56eba9dc49b20a31da4
Cr-Commit-Position: refs/heads/master@{#415231}

Powered by Google App Engine
This is Rietveld 408576698