Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: third_party/WebKit/Source/core/paint/BoxPainter.cpp

Issue 2297453002: Enable paint cache for media slider when not checking under-invalidation (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/BoxPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/BoxPainter.cpp b/third_party/WebKit/Source/core/paint/BoxPainter.cpp
index 8018fbde2898f03faef02d3d739bd4cc220de992..2ea3bd7e21ab5a3e6400c6b23b6c0d000ff1a662 100644
--- a/third_party/WebKit/Source/core/paint/BoxPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/BoxPainter.cpp
@@ -103,10 +103,10 @@ void BoxPainter::paintBoxDecorationBackgroundWithRect(const PaintInfo& paintInfo
bool paintingOverflowContents = isPaintingBackgroundOfPaintContainerIntoScrollingContentsLayer(&m_layoutBox, paintInfo);
const ComputedStyle& style = m_layoutBox.styleRef();
- // FIXME: For now we don't have notification on media buffered range change from media player
- // and miss paint invalidation on buffered range change. crbug.com/484288.
Optional<DisplayItemCacheSkipper> cacheSkipper;
- if (style.appearance() == MediaSliderPart
+ // Disable cache in under-invalidation checking mode for MediaSliderPart because we always paint using the
+ // latest data (buffered ranges, current time and duration) which may be different from the cached data.
+ if ((RuntimeEnabledFeatures::slimmingPaintUnderInvalidationCheckingEnabled() && style.appearance() == MediaSliderPart)
// We may paint a delayed-invalidation object before it's actually invalidated. Note this would be handled for
// us by LayoutObjectDrawingRecorder but we have to use DrawingRecorder as we may use the scrolling contents
// layer as DisplayItemClient below.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698