Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2297443002: DevTools: show extension name in console execution context selector. (Closed)

Created:
4 years, 3 months ago by lushnikov
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: show extension name in console execution context selector. BUG=641851 R=dgozman Committed: https://crrev.com/6d007925ee3e983d83a6a28fea59c9553f16a73a Cr-Commit-Position: refs/heads/master@{#415548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -4 lines) Patch
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 2 chunks +33 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
lushnikov
please, take a look
4 years, 3 months ago (2016-08-29 21:58:08 UTC) #1
dgozman
lgtm
4 years, 3 months ago (2016-08-31 00:57:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297443002/1
4 years, 3 months ago (2016-08-31 00:58:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 03:00:03 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 03:01:19 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6d007925ee3e983d83a6a28fea59c9553f16a73a
Cr-Commit-Position: refs/heads/master@{#415548}

Powered by Google App Engine
This is Rietveld 408576698