Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 229743004: [Mac] Fix background color of tab contents area when CoreAnimation is enabled. (Closed)

Created:
6 years, 8 months ago by miu
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Fix background color of tab contents area when CoreAnimation is enabled. The solution is to simply to call setNeedsDisplay:YES whenever the subviews are swapped in/out of the TabContentsContainerView. BUG=361424 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
miu
ccameron: PTAL. This is a one-liner fix for now since I plan to merge into ...
6 years, 8 months ago (2014-04-09 03:21:44 UTC) #1
Avi (use Gerrit)
lgtm stamp but do not land unless ccameron is happy.
6 years, 8 months ago (2014-04-09 03:25:41 UTC) #2
ccameron
This lgtm as well. It should be safe to switch to a CALayer soon.
6 years, 8 months ago (2014-04-09 07:22:37 UTC) #3
miu
The CQ bit was checked by miu@chromium.org
6 years, 8 months ago (2014-04-09 16:19:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/229743004/1
6 years, 8 months ago (2014-04-09 16:20:08 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 20:08:01 UTC) #6
Message was sent while issue was closed.
Change committed as 262788

Powered by Google App Engine
This is Rietveld 408576698