Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2297423002: Change cast's UMA product type from CHROME to CAST. (Closed)

Created:
4 years, 3 months ago by esum
Modified:
4 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, halliwell+watch_chromium.org, lcwu+watch_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, alokp+watch_chromium.org, byungchul, maclellant
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change cast's UMA product type from CHROME to CAST. BUG=internal b/30927802 Committed: https://crrev.com/5dc041a6263e3843c516b6094e5ecbee841bf4c5 Cr-Commit-Position: refs/heads/master@{#415852}

Patch Set 1 #

Patch Set 2 : Change cast's UMA product type from CHROME to CAST. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chromecast/browser/metrics/cast_metrics_service_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/proto/chrome_user_metrics_extension.proto View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
esum
Please see internal cl/130679540 for context.
4 years, 3 months ago (2016-08-31 22:40:38 UTC) #2
gfhuang
lgtm
4 years, 3 months ago (2016-08-31 22:43:31 UTC) #5
halliwell
On 2016/08/31 22:43:31, gfhuang wrote: > lgtm chromecast/ lgtm
4 years, 3 months ago (2016-08-31 23:16:16 UTC) #6
Ilya Sherman
lgtm
4 years, 3 months ago (2016-09-01 01:08:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297423002/20001
4 years, 3 months ago (2016-09-01 01:09:15 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 02:25:54 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 02:29:44 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5dc041a6263e3843c516b6094e5ecbee841bf4c5
Cr-Commit-Position: refs/heads/master@{#415852}

Powered by Google App Engine
This is Rietveld 408576698