systrace/systrace/tracing_agents/battor_trace_agent.py - Issue 2297403003: Use Systrace tracing controller in profile_chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: systrace/systrace/tracing_agents/battor_trace_agent.py

Issue 2297403003: Use Systrace tracing controller in profile_chrome (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master

Patch Set: Dynamically pass the agent list to the profile_chrome profiler Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« systrace/profile_chrome/main.py ('K') | « systrace/systrace/systrace_runner.py ('k') | systrace/systrace/tracing_agents/ftrace_agent.py » ('j') | systrace/systrace/tracing_controller.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: systrace/systrace/tracing_agents/battor_trace_agent.py

diff --git a/systrace/systrace/tracing_agents/battor_trace_agent.py b/systrace/systrace/tracing_agents/battor_trace_agent.py

index ad40ec1634768377a7763609b89ad6a5800c9f17..96137a64c49a1601bd2d1c8c5588d08862096d51 100644

--- a/systrace/systrace/tracing_agents/battor_trace_agent.py

+++ b/systrace/systrace/tracing_agents/battor_trace_agent.py

@@ -19,10 +19,10 @@ from systrace import tracing_agents

def try_create_agent(config):

if config.from_file is not None:

- return False

+ return None

if config.battor:

return BattorTraceAgent()

- return False

+ return None

class BattorConfig(tracing_agents.TracingConfig):

« systrace/profile_chrome/main.py ('K') | « systrace/systrace/systrace_runner.py ('k') | systrace/systrace/tracing_agents/ftrace_agent.py » ('j') | systrace/systrace/tracing_controller.py » ('J')