systrace/profile_chrome/chrome_tracing_agent_unittest.py - Issue 2297403003: Use Systrace tracing controller in profile_chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: systrace/profile_chrome/chrome_tracing_agent_unittest.py

Issue 2297403003: Use Systrace tracing controller in profile_chrome (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master

Patch Set: Dynamically pass the agent list to the profile_chrome profiler Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« systrace/bin/adb_profile_chrome_startup ('K') | « systrace/profile_chrome/chrome_tracing_agent.py ('k') | systrace/profile_chrome/ddms_tracing_agent.py » ('j') | systrace/profile_chrome/main.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: systrace/profile_chrome/chrome_tracing_agent_unittest.py

diff --git a/systrace/profile_chrome/chrome_tracing_agent_unittest.py b/systrace/profile_chrome/chrome_tracing_agent_unittest.py

index 27df2c7ae3bbe7c3a9f8ac2b66919b2b91e4a6c0..2fd0692347a512023ce8e6a48ac38b1247e5c0ff 100644

--- a/systrace/profile_chrome/chrome_tracing_agent_unittest.py

+++ b/systrace/profile_chrome/chrome_tracing_agent_unittest.py

@@ -26,9 +26,8 @@ class ChromeAgentTest(agents_unittest.BaseAgentTest):

ring_buffer)

agent.StartAgentTracing(chrome_tracing_agent.ChromeConfig(categories, None,

- None, None, None,

- None, None,

- None))

+ None, None, None, None, None, None, ring_buffer, self.device,

+ self.package_info))

agent.StopAgentTracing()

result = agent.GetResults()

json.loads(result.raw_data)