cros/ash: Only show the stylus palette on the internal display.

cros/ash: Only show the stylus palette on the internal display.

This avoids some issues with showing multiple palettes at the same time since each palette tool has some state that needs to be synchronized across each instance.

TEST=ash_unittests
BUG=642887
Committed: https://crrev.com/07c5f77592d89325d3aa0850856bafb583fb3a51
Cr-Commit-Position: refs/heads/master@{#416406}

[jdufault, 2016-08-31 20:52:09]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 20:53:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2016-08-31 20:58:00]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 20:58:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 22:03:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 22:03:13]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-08-31 23:34:57]

Patchset #1 (id:1) has been deleted

[jdufault, 2016-08-31 23:52:34]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 23:52:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 00:35:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 00:35:08]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-09-01 16:31:55]

Patchset #1 (id:20001) has been deleted

[jdufault, 2016-09-01 16:32:38]

Description was changed from

==========
Only show the stylus palette on the internal display.

This avoids some issues with showing multiple palettes at the same time since
each palette tool has some state that needs to be synchronized across each
instance.

BUG=642887
==========

to

==========
Only show the stylus palette on the internal display.

This avoids some issues with showing multiple palettes at the same time since
each palette tool has some state that needs to be synchronized across each
instance.

BUG=642887
==========

[jdufault, 2016-09-01 16:32:39]

jdufault@chromium.org changed reviewers:
+ oshima@chromium.org

[jdufault, 2016-09-01 16:33:32]

jdufault@chromium.org changed reviewers:
- oshima@chromium.org

[jdufault, 2016-09-01 16:34:44]

Description was changed from

==========
Only show the stylus palette on the internal display.

This avoids some issues with showing multiple palettes at the same time since
each palette tool has some state that needs to be synchronized across each
instance.

BUG=642887
==========

to

==========
cros/ash: Only show the stylus palette on the internal display.

This avoids some issues with showing multiple palettes at the same time since
each palette tool has some state that needs to be synchronized across each
instance.

TEST=ash_unittests
BUG=642887
==========

[jdufault, 2016-09-01 16:34:44]

jdufault@chromium.org changed reviewers:
+ jamescook@chromium.org

[jdufault, 2016-09-01 16:35:51]

jamescook@ PTAL.

Post m54 we may want to enable the palette on multiple displays, but this is the
simplest way to have multiple displays work properly in m54.

[James Cook, 2016-09-01 17:00:55]

LGTM with nit

https://codereview.chromium.org/2297393002/diff/40001/ash/common/ash_switches.h
File ash/common/ash_switches.h (right):

https://codereview.chromium.org/2297393002/diff/40001/ash/common/ash_switches...
ash/common/ash_switches.h:33: ASH_EXPORT extern const char
kAshEnablePaletteExperimentalFeatures[];
I like that you renamed this so everything starts with Palette.

https://codereview.chromium.org/2297393002/diff/40001/ash/common/system/statu...
File ash/common/system/status_area_widget.cc (right):

https://codereview.chromium.org/2297393002/diff/40001/ash/common/system/statu...
ash/common/system/status_area_widget.cc:260:
display::Screen::GetScreen()->GetDisplayNearestWindow(GetNativeWindow());
Use WmLookup::Get()->GetWindowForWidget(this)->GetDisplayNearestWindow()
instead. (You'd have no way of knowing this, but I suspect what you have
wouldn't work on mustash since GetNativeWidget() returns aura::Window.)

[jdufault, 2016-09-02 20:12:37]

https://codereview.chromium.org/2297393002/diff/40001/ash/common/ash_switches.h
File ash/common/ash_switches.h (right):

https://codereview.chromium.org/2297393002/diff/40001/ash/common/ash_switches...
ash/common/ash_switches.h:33: ASH_EXPORT extern const char
kAshEnablePaletteExperimentalFeatures[];
On 2016/09/01 17:00:55, James Cook wrote:
> I like that you renamed this so everything starts with Palette.

:)

https://codereview.chromium.org/2297393002/diff/40001/ash/common/system/statu...
File ash/common/system/status_area_widget.cc (right):

https://codereview.chromium.org/2297393002/diff/40001/ash/common/system/statu...
ash/common/system/status_area_widget.cc:260:
display::Screen::GetScreen()->GetDisplayNearestWindow(GetNativeWindow());
On 2016/09/01 17:00:55, James Cook wrote:
> Use WmLookup::Get()->GetWindowForWidget(this)->GetDisplayNearestWindow()
> instead. (You'd have no way of knowing this, but I suspect what you have
> wouldn't work on mustash since GetNativeWidget() returns aura::Window.)

Done.

[jdufault, 2016-09-02 20:12:48]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org

[jdufault, 2016-09-02 20:13:22]

achuith@ PTAL at chrome/*. Thanks!

[achuithb, 2016-09-02 23:16:35]

On 2016/09/02 20:13:22, jdufault wrote:
> achuith@ PTAL at chrome/*. Thanks!

lgtm, only looked at restart request

[jdufault, 2016-09-02 23:18:09]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-09-02 23:18:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2297393002/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2016-09-02 23:18:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 00:11:31]

Description was changed from

==========
cros/ash: Only show the stylus palette on the internal display.

This avoids some issues with showing multiple palettes at the same time since
each palette tool has some state that needs to be synchronized across each
instance.

TEST=ash_unittests
BUG=642887
==========

to

==========
cros/ash: Only show the stylus palette on the internal display.

This avoids some issues with showing multiple palettes at the same time since
each palette tool has some state that needs to be synchronized across each
instance.

TEST=ash_unittests
BUG=642887
==========

[commit-bot: I haz the power, 2016-09-03 00:11:33]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-09-03 00:14:37]

Description was changed from

==========
cros/ash: Only show the stylus palette on the internal display.

This avoids some issues with showing multiple palettes at the same time since
each palette tool has some state that needs to be synchronized across each
instance.

TEST=ash_unittests
BUG=642887
==========

to

==========
cros/ash: Only show the stylus palette on the internal display.

This avoids some issues with showing multiple palettes at the same time since
each palette tool has some state that needs to be synchronized across each
instance.

TEST=ash_unittests
BUG=642887

Committed: https://crrev.com/07c5f77592d89325d3aa0850856bafb583fb3a51
Cr-Commit-Position: refs/heads/master@{#416406}
==========

[commit-bot: I haz the power, 2016-09-03 00:14:38]

Patchset 2 (id:??) landed as
https://crrev.com/07c5f77592d89325d3aa0850856bafb583fb3a51
Cr-Commit-Position: refs/heads/master@{#416406}