components/user_prefs/tracked/pref_hash_filter_unittest.cc - Issue 2297373002: Refactor PrefHashStore's BeginTransaction to take a rawptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/user_prefs/tracked/pref_hash_filter_unittest.cc

Issue 2297373002: Refactor PrefHashStore's BeginTransaction to take a rawptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/user_prefs/tracked/pref_hash_filter.cc ('k') | components/user_prefs/tracked/pref_hash_store.h » ('j') | components/user_prefs/tracked/pref_hash_store.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/user_prefs/tracked/pref_hash_filter_unittest.cc

diff --git a/components/user_prefs/tracked/pref_hash_filter_unittest.cc b/components/user_prefs/tracked/pref_hash_filter_unittest.cc

index 97201b5a1e618fa85ecca089bd38e578e71522d2..4c705367cad33391a7fd99affd2d15e07afd7306 100644

--- a/components/user_prefs/tracked/pref_hash_filter_unittest.cc

+++ b/components/user_prefs/tracked/pref_hash_filter_unittest.cc

@@ -157,7 +157,7 @@ class MockPrefHashStore : public PrefHashStore {

// PrefHashStore implementation.

std::unique_ptr<PrefHashStoreTransaction> BeginTransaction(

- std::unique_ptr<HashStoreContents> storage) override;

+ HashStoreContents* storage) override;

private:

// A MockPrefHashStoreTransaction is handed to the caller on

@@ -247,7 +247,7 @@ void MockPrefHashStore::SetInvalidKeysResult(

}

std::unique_ptr<PrefHashStoreTransaction> MockPrefHashStore::BeginTransaction(

- std::unique_ptr<HashStoreContents> storage) {

+ HashStoreContents* storage) {

EXPECT_FALSE(transaction_active_);

return std::unique_ptr<PrefHashStoreTransaction>(

new MockPrefHashStoreTransaction(this));