Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2297363004: Update third_party/pkg/stack_trace to 1.6.6 (Closed)

Created:
4 years, 3 months ago by Bill Hesse
Modified:
4 years, 3 months ago
Reviewers:
mit
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update third_party/pkg/stack_trace to 1.6.6 All packages in third_party except markdown are now at the latest released version. Markdown will be rolled in a separate CL. BUG= R=mit@google.com Committed: https://github.com/dart-lang/sdk/commit/2a7946817b348b93e0b5bb224bccfa57b6e4d9c0

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M DEPS View 4 chunks +7 lines, -7 lines 0 comments Download
M pkg/pkgbuild.status View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Bill Hesse
4 years, 3 months ago (2016-09-01 09:31:45 UTC) #2
mit
On 2016/09/01 09:31:45, Bill Hesse wrote: See comment. Shouldn't the title and description be more ...
4 years, 3 months ago (2016-09-01 11:45:54 UTC) #3
mit
See comment. Shouldn't the title and description be more generic? https://codereview.chromium.org/2297363004/diff/1/pkg/pkgbuild.status File pkg/pkgbuild.status (right): https://codereview.chromium.org/2297363004/diff/1/pkg/pkgbuild.status#newcode9 ...
4 years, 3 months ago (2016-09-01 11:46:17 UTC) #4
Bill Hesse
The other changes are minor, but the stack_trace update is major, and is the reason ...
4 years, 3 months ago (2016-09-01 11:54:56 UTC) #5
mit
On 2016/09/01 11:54:56, Bill Hesse wrote: > The other changes are minor, but the stack_trace ...
4 years, 3 months ago (2016-09-01 11:59:52 UTC) #6
Bill Hesse
4 years, 3 months ago (2016-09-01 12:01:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2a7946817b348b93e0b5bb224bccfa57b6e4d9c0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698