Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2297363002: Subzero: Fix a build error against LLVM trunk. (Closed)

Created:
4 years, 3 months ago by Jim Stichnoth
Modified:
4 years, 3 months ago
Reviewers:
Eric Holk, Karl, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix a build error against LLVM trunk. LLVM commit 1d79fff9e65e77f84bf80c2cf4f0155bd167c90d changed the way ilist::reverse_iterator is converted to ilist::iterator. See https://github.com/llvm-mirror/llvm/commit/1d79fff9e65e77f84bf80c2cf4f0155bd167c90d BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7c9728faead1368150bcaa8313bc460df29ea1b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/IceInst.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Jim Stichnoth
4 years, 3 months ago (2016-08-31 20:33:20 UTC) #4
Karl
lgtm
4 years, 3 months ago (2016-08-31 20:38:56 UTC) #5
Jim Stichnoth
4 years, 3 months ago (2016-08-31 20:42:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7c9728faead1368150bcaa8313bc460df29ea1b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698