Flush results when contexts are made idle.

Flush results when contexts are made idle.


R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/f096f7b9855f65ebc8442e001a52a469aa6a74d6

[Brian Wilkerson, 2016-08-31 19:26:34]

https://codereview.chromium.org/2297343002/diff/1/pkg/analysis_server/test/do...
File pkg/analysis_server/test/domain_completion_test.dart (right):

https://codereview.chromium.org/2297343002/diff/1/pkg/analysis_server/test/do...
pkg/analysis_server/test/domain_completion_test.dart:313:
fail_inDartDoc_reference1() async {
Should we use @failingTest?

More importantly, why are these tests now failing?

[scheglov, 2016-08-31 19:48:56]

https://codereview.chromium.org/2297343002/diff/1/pkg/analysis_server/test/do...
File pkg/analysis_server/test/domain_completion_test.dart (right):

https://codereview.chromium.org/2297343002/diff/1/pkg/analysis_server/test/do...
pkg/analysis_server/test/domain_completion_test.dart:313:
fail_inDartDoc_reference1() async {
On 2016/08/31 19:26:34, Brian Wilkerson wrote:
> Should we use @failingTest?
> 
> More importantly, why are these tests now failing?

Yes, it would be better.
Unfortunately analysis_server uses the package 'test_reflective_loader', which
does not have this feature yet.
I will update it, and switch analyzer to using the same package instead of its
own copy.

These tests are failing because completion uses RESOLVED_UNIT5 for parts.
And we now aggressively flush ASTs.
Although in theory it was flaky even before.
I think this completer should be reimplemented using element model.

[Brian Wilkerson, 2016-08-31 19:56:50]

https://codereview.chromium.org/2297343002/diff/1/pkg/analysis_server/test/do...
File pkg/analysis_server/test/domain_completion_test.dart (right):

https://codereview.chromium.org/2297343002/diff/1/pkg/analysis_server/test/do...
pkg/analysis_server/test/domain_completion_test.dart:313:
fail_inDartDoc_reference1() async {
> These tests are failing because completion uses RESOLVED_UNIT5 for parts.
> And we now aggressively flush ASTs.

Yes, but we should be aggressively re-computing the resolved AST's, so that
doesn't explain the failures.

[scheglov, 2016-08-31 20:56:09]

PTAL

The completion tests that were failing stopped failing after switching to the
new test_reflective_loader. It has a fix for async tests.

[Brian Wilkerson, 2016-08-31 20:58:50]

lgtm

[scheglov, 2016-08-31 21:03:31]

Description was changed from

==========
Flush results when contexts are made idle.


R=brianwilkerson@google.com
BUG=
==========

to

==========
Flush results when contexts are made idle.


R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/f096f7b9855f65ebc8442e001a52a469aa6a74d6
==========

[scheglov, 2016-08-31 21:03:32]

Committed patchset #2 (id:20001) manually as
f096f7b9855f65ebc8442e001a52a469aa6a74d6 (presubmit successful).